Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Pankaj Gupta <pankaj.gupta@nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "clin@suse.com" <clin@suse.com>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "pierre.gondois@arm.com" <pierre.gondois@arm.com>,
        Jacky Bai <ping.bai@nxp.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        Wei Fang <wei.fang@nxp.com>, Peng Fan <peng.fan@nxp.com>,
        Bough Chen <haibo.chen@nxp.com>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>,
        Sahil Malhotra <sahil.malhotra@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>
Subject: RE: [EXT] Re: [PATCH v4 2/7] arm64: dts: imx8ulp-evk: added nxp
 secure enclave firmware
Thread-Topic: [EXT] Re: [PATCH v4 2/7] arm64: dts: imx8ulp-evk: added nxp
 secure enclave firmware
Thread-Index: AQHZtLo4vD63ufm320WJ9kJWTP24Za+2dl8AgBIVjdCAGBmKgIAK4p4Q
Date:   Tue, 15 Aug 2023 13:03:34 +0000
Message-ID: <DU2PR04MB8630E7B069A9F9CF2889636C9514A@DU2PR04MB8630.eurprd04.prod.outlook.com>
References: <20230712121219.2654234-1-pankaj.gupta@nxp.com>
 <20230712121219.2654234-3-pankaj.gupta@nxp.com>
 <1ac2fb68-02e0-ddfe-87aa-fcd093779009@linaro.org>
 <DU2PR04MB86306E154C195F69368D3AB8950DA@DU2PR04MB8630.eurprd04.prod.outlook.com>
 <701ad779-0d1e-e8e6-8eba-294452cfb0bc@linaro.org>
In-Reply-To: <701ad779-0d1e-e8e6-8eba-294452cfb0bc@linaro.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?afxE2c/9StKhZjdaTvVSNpKv2kqIWOzQ9UoQLMjU/9XRkKDxSedpGI6cckrX?=
 =?us-ascii?Q?v5HL5mC9rrdW5iHkMegSwrzx/FHadB1awqkLLrat2HmmPmv2RSkPdU3t9MbF?=
 =?us-ascii?Q?62tL0jB9/MwWqbdnGs+aocM02U4i3VOIce3ow0ocbQucOcg6wpEQz6K/SK0/?=
 =?us-ascii?Q?HDrF867uZaUgf1UVmdWwQD1cWDG6lZDRACvRKd6c0u02D/ufglfntU7t+/tj?=
 =?us-ascii?Q?5NRCFH9rSK0EhlOlnpcqPNzvYbAq8RfdralGyGCXyRtrTh92l3DBcEpGaUI9?=
 =?us-ascii?Q?pNtn32OVpQkji8EUeKkWD384eg8gfGqshaZJLJLAAepoa04rqgn4TXwLDf0a?=
 =?us-ascii?Q?jwMNQxjNHAO0fiZMhfch8H1A+I1RcXeW/rwaFNkOf0LigbfJjDRvB/O3TNsl?=
 =?us-ascii?Q?Y3sAoJNC7oFNjrhQ6v24QYUxaF9bWEeuKJ60hH5QApGL/gOMr/5vYE75Maph?=
 =?us-ascii?Q?xgmbaLfHjQHPrpbD42x7bB8YOmWGIJMnxAn6xh8pAUP1oW/Ad9KIiMNqSetw?=
 =?us-ascii?Q?OhzQW4HGtWBihW1VSu8rbV1t4g639Yomx6+w/MpNOhHwWB4ApaC6GxFF89g4?=
 =?us-ascii?Q?6hrfHqsXYMLfmuNDEl02lKnFe8B1n81q6ktsqzYAOIua8UXZUIGc1ULOL7jx?=
 =?us-ascii?Q?xKB10O8dYu5xqfBdgBLD1LIF9aeiUGREgUoVqCBQFxCsCF+J2pVB5CQGipy6?=
 =?us-ascii?Q?cJ45qUpq9ZRAxQouAp2zsJvKbDlOyo1xt6q6GnHHhuyCTZfFtLcH+U72q1SP?=
 =?us-ascii?Q?oqZXVUi5/5yKTNoyAeA2y7IB58geXwUlGBSNqxEanN0yA40vXjes/rejVcxQ?=
 =?us-ascii?Q?lklzOWI6uAMY7W8fp47KVABl58G1U/7HAcipQt/QzIS6v1XT6/PRQdy676Kb?=
 =?us-ascii?Q?S41lMg/6Km1c2l9l2zrg8JfGW8QQc1fFRcCXY1jKbRmx4gZUWISSQMKDKnry?=
 =?us-ascii?Q?d4KVb7HqUH8hZ98WXqvkd2STV/lTo9IjKTrFXSJXWxLGWJ+5JTjeswG3u+71?=
 =?us-ascii?Q?8iKLqs9QIzmcFDjyWtlMA7V/3ggtZPnDxHD9BAtrd4lhmTqTRmhS8Rm/Rc2o?=
 =?us-ascii?Q?CwXNVKckqIs4Lubw52v9/uoUUATN5IHWTscRvx+BkGSMXHyyxhvoC7KO22s6?=
 =?us-ascii?Q?PVtJgefbSfUNJC1DgWI2mK1P1YQCdybFfl5TsGeGQg8alDh5NoQiWBib7LNN?=
 =?us-ascii?Q?53Qf5vC+Y8JFDCLkGCMVF/YITg/FoGngPITf9V0jxxd5njVGjp1ACNLb6giz?=
 =?us-ascii?Q?1Gbngw8w39oUVu3372IZONo9cJBwiZB75+6SwdUxN08TTmuUj59MlilSMqOu?=
 =?us-ascii?Q?GcvolAvmeue8rBb5PGsizKUUI8i/06i20Yff73KFsYdzw57kvMs44zch+j0o?=
 =?us-ascii?Q?3RyXE1kcqKiVUwFt2Tgjn7M2TNOijv1h05tTmiz6t+5tQ1L7F1YQw7OmCkRZ?=
 =?us-ascii?Q?rbkNTKgiTDdlPUDifgZ3R3lvtHwY0bzLPv8RdlFQkMg9m6vFPR4BMV8ncIPn?=
 =?us-ascii?Q?Imo613mJpC/M3tHGvTT1DkgnIMLRsU76kRGVdkt3FUfSKlG2SpjAQWZfN4QX?=
 =?us-ascii?Q?jDSQKDcfRWsVT5VRH/aflkgpc1JlkJF590de+RQ0?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8630.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 637d0243-f9d7-4a75-18d4-08db9d900858
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2023 13:03:34.3330
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SqSRpYeoczIGVJ72jSoSizPootJBxPJw2A/2mzim2YGRQ62tAzkPNulGAJQNtrCmWhmp2AkKBOpXQSwVtCPpPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9718
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Tuesday, August 8, 2023 8:19 PM
> To: Pankaj Gupta <pankaj.gupta@nxp.com>; shawnguo@kernel.org;
> s.hauer@pengutronix.de; kernel@pengutronix.de; clin@suse.com;
> conor+dt@kernel.org; pierre.gondois@arm.com; Jacky Bai
> <ping.bai@nxp.com>; Clark Wang <xiaoning.wang@nxp.com>; Wei Fang
> <wei.fang@nxp.com>; Peng Fan <peng.fan@nxp.com>; Bough Chen
> <haibo.chen@nxp.com>; festevam@gmail.com; dl-linux-imx <linux-
> imx@nxp.com>; davem@davemloft.net; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Gaurav Jain
> <gaurav.jain@nxp.com>; alexander.stein@ew.tq-group.com; Sahil Malhotra
> <sahil.malhotra@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>;
> Varun Sethi <V.Sethi@nxp.com>
> Subject: Re: [EXT] Re: [PATCH v4 2/7] arm64: dts: imx8ulp-evk: added nxp
> secure enclave firmware
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>=20
>=20
> On 08/08/2023 13:07, Pankaj Gupta wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Sent: Thursday, July 13, 2023 12:08 AM
> >> To: Pankaj Gupta <pankaj.gupta@nxp.com>; shawnguo@kernel.org;
> >> s.hauer@pengutronix.de; kernel@pengutronix.de; clin@suse.com;
> >> conor+dt@kernel.org; pierre.gondois@arm.com; Jacky Bai
> >> <ping.bai@nxp.com>; Clark Wang <xiaoning.wang@nxp.com>; Wei Fang
> >> <wei.fang@nxp.com>; Peng Fan <peng.fan@nxp.com>; Bough Chen
> >> <haibo.chen@nxp.com>; festevam@gmail.com; dl-linux-imx <linux-
> >> imx@nxp.com>; davem@davemloft.net; robh+dt@kernel.org;
> >> krzysztof.kozlowski+dt@linaro.org;
> >> linux-arm-kernel@lists.infradead.org;
> >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Gaurav Jain
> >> <gaurav.jain@nxp.com>; alexander.stein@ew.tq-group.com; Sahil
> >> Malhotra <sahil.malhotra@nxp.com>; Aisheng Dong
> >> <aisheng.dong@nxp.com>; Varun Sethi <V.Sethi@nxp.com>
> >> Subject: [EXT] Re: [PATCH v4 2/7] arm64: dts: imx8ulp-evk: added nxp
> >> secure enclave firmware
> >>
> >> Caution: This is an external email. Please take care when clicking
> >> links or opening attachments. When in doubt, report the message using
> >> the 'Report this email' button
> >>
> >>
> >> On 12/07/2023 14:12, Pankaj Gupta wrote:
> >>> Added support for NXP secure enclave called EdgeLock Enclave
> >>> firmware
> >>> (se-fw) for imx8ulp-evk.
> >>>
> >>> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> >>> ---
> >>>  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 12 +++++++++++-
> >>>  1 file changed, 11 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> >>> b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> >>> index 3ddc0f3125b3..10ed31974a6f 100644
> >>> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> >>> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> >>> @@ -114,7 +114,7 @@ sosc: clock-sosc {
> >>>               #clock-cells =3D <0>;
> >>>       };
> >>>
> >>> -     sram@2201f000 {
> >>> +     sram0: sram@2201f000 {
> >>>               compatible =3D "mmio-sram";
> >>>               reg =3D <0x0 0x2201f000 0x0 0x1000>;
> >>>
> >>> @@ -161,6 +161,16 @@ s4muap: mailbox@27020000 {
> >>>                       #mbox-cells =3D <2>;
> >>>               };
> >>>
> >>> +             ele_fw: se-fw {
> >>> +                     compatible =3D "fsl,imx-ele";
> >>> +                     mboxes =3D <&s4muap 0 0 &s4muap 1 0>;
> >>> +                     mbox-names =3D "tx", "rx";
> >>> +                     fsl,mu-did =3D <7>;
> >>> +                     fsl,mu-id =3D <2>;
> >>> +                     sram-pool =3D <&sram0>;
> >>
> >> It does not look like you tested the DTS against bindings. Please run
> >> `make dtbs_check` (see
> >> Documentation/devicetree/bindings/writing-schema.rst or
> >>

Following tests (1 &2) were performed:

1.  make -j32. Build the images and DTB to test the functionality.

2. make dt_binding_check DT_SCHEMA_FILES=3Dfreescale.

3. make CHECK_DTBS=3Dy freescale/imx8ulp-evk.dtb

Before sending the V4 patch for review, I have ran tests 1 &2. Both were pa=
ssing.
But after seeing the page shared by you, ran the 3rd test and I was able to=
 reproduce the issue, you might be referring to.

For V5, I will perform all the 3 tests.

> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fww
> w
> >> .li%2F&data=3D05%7C01%7Cpankaj.gupta%40nxp.com%7Cfce997832862
> 4056830408
> >>
> db981e9af6%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6382
> 710294401
> >>
> 41352%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
> luMzIiLCJ
> >>
> BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DKi%2BHqff7
> rZbTAnAbJ
> >> ZgRiwxGUx0qJjYzxIjMHNoyM8s%3D&reserved=3D0
> >> naro.org%2Fblog%2Ftips-and-tricks-for-validating-devicetree-sources-w
> >> ith-
> >> the-devicetree-
> >>
> schema%2F&data=3D05%7C01%7Cpankaj.gupta%40nxp.com%7Cd13d0b68d0
> 1c
> >>
> 4d10d8cb08db83070ed2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%
> >>
> 7C0%7C638247838553225400%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM
> C
> >>
> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000
> %7
> >>
> C%7C%7C&sdata=3DpO6dnz4aPqVejRNDR0OU4n04hXebyqgrNKg4DPhahI0%3
> D
> >> &reserved=3D0
> >> for instructions).
> >
> > Tested. Before submitting the patch.
> > [Pankaj] Accepted.
>=20
> You really tested that patch? Before I waste my time on proving it was no=
t,
> are you 100% sure that you tested that patch and no new warnings are
> printed? Or are you just agreeing with me that this time you will test?
> >
>=20
> Best regards,
> Krzysztof