Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Will Deacon <will@kernel.org>
To:     Tomislav Novak <tnovak@meta.com>,
        Catalin Marinas <catalin.marinas@arm.com>
Cc:     kernel-team@android.com, Will Deacon <will@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Mark Rutland <mark.rutland@arm.com>,
        Samuel Gosselin <sgosselin@google.com>
Subject: Re: [PATCH v2] hw_breakpoint: fix single-stepping when using bpf_overflow_handler
Date:   Fri, 18 Aug 2023 19:04:10 +0100
Message-Id: <169237465034.1400900.4830514571452045431.b4-ty@kernel.org>
In-Reply-To: <20230605191923.1219974-1-tnovak@meta.com>
References: <ZH40hgYbWc0x+1c3@tnovak-mbp.dhcp.thefacebook.com> <20230605191923.1219974-1-tnovak@meta.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 5 Jun 2023 12:19:23 -0700, Tomislav Novak wrote:
> Arm platforms use is_default_overflow_handler() to determine if the
> hw_breakpoint code should single-step over the breakpoint trigger or
> let the custom handler deal with it.
> 
> Since bpf_overflow_handler() currently isn't recognized as a default
> handler, attaching a BPF program to a PERF_TYPE_BREAKPOINT event causes
> it to keep firing (the instruction triggering the data abort exception
> is never skipped). For example:
> 
> [...]

Applied to will (for-next/perf), thanks!

[1/1] hw_breakpoint: fix single-stepping when using bpf_overflow_handler
      https://git.kernel.org/will/c/d11a69873d9a

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev