Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20230815190949.GA3207581@google.com> <6a234118-1ad2-4e22-ad80-f35a1dab8f03@paulmck-laptop>
In-Reply-To: <6a234118-1ad2-4e22-ad80-f35a1dab8f03@paulmck-laptop>
From:   Joel Fernandes <joel@joelfernandes.org>
Date:   Wed, 16 Aug 2023 19:27:03 -0400
Message-ID: <CAEXW_YQkPOPXEwTCc3nZ2CH_scOomPgz7ACYECi3k64T+YD5Vg@mail.gmail.com>
Subject: Re: [PATCH v3] rcutorture: Copy out ftrace into its own console file
To:     paulmck@kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Josh Triplett <josh@joshtriplett.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Shuah Khan <shuah@kernel.org>, Joel <agnel.joel@gmail.com>,
        rcu@vger.kernel.org, linux-kselftest@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 16, 2023 at 6:57=E2=80=AFPM Paul E. McKenney <paulmck@kernel.or=
g> wrote:
>
> On Tue, Aug 15, 2023 at 07:09:49PM +0000, Joel Fernandes (Google) wrote:
> > When debugging, it can be difficult to quickly find the ftrace dump
> > within the console log, which in turn makes it difficult to process it
> > independent of the result of the console output.  This commit therefore
> > copies the contents of the buffers into its own file to make it easier
> > to locate and process the ftrace dump. The original ftrace dump is stil=
l
> > available in the console log in cases where it is more convenient to
> > process it there, for example, when you have a script that processes
> > console output as well as ftrace-dump data.
> >
> > Also handle the case of multiple ftrace dumps potentially showing up in=
 the
> > log. Example for a file like [1], it will extract as [2].
> >
> > [1]:
> > foo
> > foo
> > Dumping ftrace buffer:
> > ---------------------------------
> > blah
> > blah
> > ---------------------------------
> > more
> > bar
> > baz
> > Dumping ftrace buffer:
> > ---------------------------------
> > blah2
> > blah2
> > ---------------------------------
> > bleh
> > bleh
> >
> > [2]:
> >
> > Ftrace dump 1:
> > blah
> > blah
> >
> > Ftrace dump 2:
> > blah2
> > blah2
> >
> >
> > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
>
> Very good, and I did queue this one.
>
> I fixed the indentation of the awk script.  Perhaps your text editor is
> being too smart for our good?  ;-)

Thanks!  Yes the editor messing up is a possibility, I'll go look at
that, though the indent seems still messed up in your dev branch:

The line "/Dumping ftrace buffer:/ " has spaces, as does the "awk <
$1" line. Is that intentional?  All the following ones have tabs.

thanks,

 - Joel