Received: by 2002:a05:7412:bc1a:b0:d7:7d3a:4fe2 with SMTP id ki26csp454605rdb; Sat, 19 Aug 2023 08:18:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGuGztEIEK+fd8dSDb5GeNlJ3q4n2qEpQvhlKEzbny3fR5p7LRxKr/AFzwr7yk5Grs7pio2 X-Received: by 2002:a17:90a:13cb:b0:26d:4695:4040 with SMTP id s11-20020a17090a13cb00b0026d46954040mr1980980pjf.4.1692458338963; Sat, 19 Aug 2023 08:18:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692458338; cv=none; d=google.com; s=arc-20160816; b=b2KVxcVhid+wB/P3lq3xjAAPPmqL4C3SPPqADyDP/v1l98yZCz9ml1DzQJFIEUKxOB TafnjBfgyL5DqNEsSIMGYeQzyiZRXjfJ2E/PHfyfxOeCyPZ70pHJe04pblfREGv6l4GV OM/sWqWO/kzdO7DeUqiNH+2l8tu2ieXmpjSodK9mdvIfOHx8AbHDTL1Hg/wVu6Qw0O98 KkeWBuRljQ9H1W37TP79k+16Btlj+e1UvknSCbw+lgf+nAL2Gm++jx8LKVQ5223+qw43 8bWDRaugv7sAqNMi7VfxL9+tCzDguKHceWqXemZy5WbGyRT8n0VX3bgXJRYDZ6qG81n2 RYbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RWf3NctEzpi165Atgt5iJpY7j96ObPGlkJlrAWYSV1g=; fh=KdXH1yDzMevhSDh5KaC3+fGGbBUUsdYKKc0V+oSk31U=; b=hpRkSFO+AfFjqWZ0oCtwcrRpAQuYaCVaSRmMRxh/fB2Hs5QLxaopvOx5//J/BrB353 smtGgycnfKNIFJWGRv1aB0fisPC6UR3sl+Dr5jUERBzN+fghXqqa9nuRnVrWlrCFYKpl Jhvn7z8B/HKdRMs2fDAj6xweivea1FMXpA/iMS9si6tU0BL2fkJQy05X7v8MdNP8Ukow LQBkyA/ViCSowvgQOd/Ysk2XaLIk6tuDBybFQhWtCGzn4XoZ/QEvPDHGdCRyxg6Hxznj 2w8qOowtNlxNLepDh1cPkIaJxS4rK2og1ohNsfLLWF4ZM9KZ6IiBsnoHtG9Z9rBu2cQ8 zYag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cyMuaqGW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id h20-20020a17090aa89400b00262fa96d9e6si3688418pjq.142.2023.08.19.08.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Aug 2023 08:18:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cyMuaqGW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F3461E3211; Sat, 19 Aug 2023 01:46:56 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343803AbjHPOwl (ORCPT + 99 others); Wed, 16 Aug 2023 10:52:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343846AbjHPOwg (ORCPT ); Wed, 16 Aug 2023 10:52:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB93F121 for ; Wed, 16 Aug 2023 07:52:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 58A596446C for ; Wed, 16 Aug 2023 14:52:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A2CAC433C8; Wed, 16 Aug 2023 14:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692197554; bh=/VrFeNd6P2bZrXsUoUgvGF/6yGQy/1jlfunGhRdur7w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cyMuaqGW1I2WiVlf5tJq5dbbLvvg6Cwcz4cgTEecf4IZ/elHKbIb2IJWlkam4Nxhs 3eqPANpWfUB2pHL9Hm2JmC+l67zk8/BIIDBdWHX7PtvT5mgLVol85sRbrdbPnFn0n7 UF0fawFK0D99hyJCl+MERv6B2OHX+LUBiUFl/NPMmsYACCX3n2OGuvdwuA0zqn2Rki YTr23LrzsbmfTpsPbD7BNCE0g+JP49LbAZO2kv3JHC7+KD9sR+AE/pLFje/uBQVjKu EYkQB472qFWKoRvAyFGJSuFBHKIlVT6iWoNJlre2VRGYJb1Y1iCQQm2YRVEsNaPzd1 PLfL7fkbQosYw== Date: Wed, 16 Aug 2023 07:52:32 -0700 From: Nathan Chancellor To: Borislav Petkov Cc: Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org, David.Kaplan@amd.com, Andrew.Cooper3@citrix.com, jpoimboe@kernel.org, gregkh@linuxfoundation.org, nik.borisov@suse.com Subject: Re: [PATCH v2 05/11] x86/cpu: Clean up SRSO return thunk mess Message-ID: <20230816145232.GA1535486@dev-arch.thelio-3990X> References: <20230814114426.057251214@infradead.org> <20230814121148.842775684@infradead.org> <20230815212931.GA3863294@dev-arch.thelio-3990X> <20230815224348.GE971582@hirez.programming.kicks-ass.net> <20230816073828.GAZNx89HT8mYCOxvV1@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230816073828.GAZNx89HT8mYCOxvV1@fat_crate.local> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 16, 2023 at 09:38:28AM +0200, Borislav Petkov wrote: > On Wed, Aug 16, 2023 at 12:43:48AM +0200, Peter Zijlstra wrote: > > Yeah, Boris and me fixed that yesterday evening or so. I'm not sure > > I still have the diffs, but Boris should have them all somewhere. > > Even better - all the urgent fixes I've accumulated so far are coming up > in tip's x86/urgent. I'd appreciate people testing it. All my configurations build and run cleanly in QEMU at commit d80c3c9de067 ("x86/srso: Explain the untraining sequences a bit more") so I think we should be good here. Cheers, Nathan