Received: by 2002:a05:7412:bc1a:b0:d7:7d3a:4fe2 with SMTP id ki26csp464406rdb; Sat, 19 Aug 2023 08:42:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFV28F6xpUzNZ2NTLc69w60cdzK+vJ258B4kmTbBx+nxtioAi7VOd0k0wem1LSjFCUPbIkT X-Received: by 2002:a17:902:e746:b0:1b8:35fa:cdcc with SMTP id p6-20020a170902e74600b001b835facdccmr2674502plf.5.1692459736384; Sat, 19 Aug 2023 08:42:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692459736; cv=none; d=google.com; s=arc-20160816; b=ngiUDi5qDy/3UVw2/sPqS4JRbpMehDh742DJpHs2TSbOPIQ6ci1+d27RCnWSmlhEKN DbWqqQBYF2p+mEqL5aX2rcCrovfzm/gz1X+QhSlG95H6B1Ewb86p/kP27oCLGgbcUnfC A98H5+IKn8KVJSh6mIkfkUE5QjMmg9D/wa5w/4uJlGMCE31hTo61gScDiwnqE/1y3KXw YfKGDeWRZ/XXSTu6NzRDIcCFRwkrKnlotfmLLFJ6hvfqtUCtMXgo/Ya5nXisrLtjAvcl yubLe1FrS37NRj6jPmi34tB1psxG4K0nlZ6kAwyL/7Ac3T6xIoF6WmLmv+tpxVGfs1wn PSnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=VJ4DzJwcG+Hv6xU2mltm0I23VGRpCB+TthbicurkVYE=; fh=7drHih+V3awCgytFuf6Fn5U4jMg/Y6lLbJ3+uzzGHNE=; b=AZZuzlSWgStZc6pYy6gJ9Aiv7t2V4IC55noUhXq1AKVtUY4eZ66/PevBfie425TXAr TV3lEGNJ3FtBuRBhXcMSx2dIFlKJko1hC0/y+5tMrSFlzZUwav8Gwlk80rtgZBnWfAJv sKATke0l/IGNiHvK5uQ+uha/62FuXQ4oawkACW+VTMP31/zc/FDfCmZDjg8KSmFK3Jdy KNN1VSHG14zUnLxiO0FcAfPyal8s2jJh96j3HFfVgL7X1bJtahmEjfikPKu0NOJ6dN4v 4CyHqM6wPDXi9xgliONoViqV5cEh8KaRAYIy1EFfQjdtTDomh1NrKv2GoPMVoDddXvc7 NPUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b5-20020a170902650500b001b81fe65fa3si3580348plk.569.2023.08.19.08.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Aug 2023 08:42:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1D811EF950; Sat, 19 Aug 2023 01:48:22 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350074AbjHQK6U (ORCPT + 99 others); Thu, 17 Aug 2023 06:58:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245144AbjHQK5s (ORCPT ); Thu, 17 Aug 2023 06:57:48 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0F8A82D4A for ; Thu, 17 Aug 2023 03:57:47 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA64DD75; Thu, 17 Aug 2023 03:58:27 -0700 (PDT) Received: from ewhatever.cambridge.arm.com (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7AE8B3F762; Thu, 17 Aug 2023 03:57:45 -0700 (PDT) From: Suzuki K Poulose To: Anshuman Khandual , linux-arm-kernel@lists.infradead.org Cc: Suzuki K Poulose , Mike Leach , Mike Leach , coresight@lists.linaro.org, James Clark , Dan Carpenter , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] coresight: etm4x: Ensure valid drvdata and clock before clk_put() Date: Thu, 17 Aug 2023 11:57:33 +0100 Message-Id: <169226979802.555124.13592500454111810038.b4-ty@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230817035926.157370-1-anshuman.khandual@arm.com> References: <20230817035926.157370-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Aug 2023 09:29:26 +0530, Anshuman Khandual wrote: > This validates 'drvdata' and 'drvdata->pclk' clock before calling clk_put() > in etm4_remove_platform_dev(). The problem was detected using Smatch static > checker as reported. > > Applied, thanks! [1/1] coresight: etm4x: Ensure valid drvdata and clock before clk_put() https://git.kernel.org/coresight/c/a4621fd1d4fd Best regards, -- Suzuki K Poulose