Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <98f8dbed-5eb9-8b09-1868-5dda4162b9e3@intel.com>
Date:   Mon, 14 Aug 2023 10:49:02 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.14.0
Subject: Re: [PATCH 2/7] selftests/resctrl: Correct benchmark command help
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Shuah Khan <skhan@linuxfoundation.org>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20230808091625.12760-1-ilpo.jarvinen@linux.intel.com>
 <20230808091625.12760-3-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230808091625.12760-3-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RG5VTHVlRm1wWXBMdnd5VytZRzNWN2ZSdWFsSjNFR3MwSk13a2s2aXVVamRM?=
 =?utf-8?B?N1FRK3ZHcldnYzBJc0tUVG9rV2UrcHA4SjgzWGQ2N0FkTGg0b3ZqUWtwUTR4?=
 =?utf-8?B?R01jYnEza09wOHM3UlNIU3kyU01PTXJpVVA2Y3R6T3JLOURhNnlZRWpTZXZW?=
 =?utf-8?B?d1NhOFFQUUNMMTNKaUVRSE5XaFZ4YWJXUnI1aDJmQ0RiN3AyZEd1b0tlcTRQ?=
 =?utf-8?B?RmZ6Qi9TT0RKL1lHSlB3LzkrUVNVNm1hRnVwc0IvbmwvMVYyNllxZFdzc2tL?=
 =?utf-8?B?UzArckZEWjZ0bjlaejRSMnJYbmlZK2dtRWk1ZldNZS81WXZndnBFWkFpZHRK?=
 =?utf-8?B?azBPRkdlQm9VaXZlVzJtaWhMSi9CYTZGd3UrdTBKRnlReTY5d3FKTUVYS05w?=
 =?utf-8?B?cngwRVpqTmYxL2pBMlM5Qmw1NGYwanJOU1FHZXhCOGRwSC8wQkVRUUh4NElY?=
 =?utf-8?B?TVBVN2ZiM2FYSk1vNFFlTFdvK1p5Y2pCNGxibCtoak93cGI3Mk5wNUNjMUxa?=
 =?utf-8?B?aEN0RkZ3bEdoaGRhUXZMenlTamY4SEJsL2JEZFlqQUhDdEowRXJjeko0cndm?=
 =?utf-8?B?UmVHQ0c4bWdFL2lUWDQ0QzRJSmtVaHJyYXZFNnJLSHZTYnh6emc4bXFUMGhV?=
 =?utf-8?B?bERSUG5BbEFkZXNGOEVvdDkrY0dBTUFVOG5GSFlyaHZQbFBXUXJmOGFublVD?=
 =?utf-8?B?ZDR5cEM5TEFNM3pKSjh0ZVdLdnVwcElRd3NhTXdWYlFia3Q2NE9ZY1BFaFB0?=
 =?utf-8?B?eERxcFAvSERKU2RBNCtkaVRDYjhNeVcwWXl2bVR2WXhpYkQyQytWVDJVdEVa?=
 =?utf-8?B?YUZDSzQveUlFMHZWTWMxZU1QZU9BbGczalFHNHVXV3M5aVM0UVZ5cHZHQWVu?=
 =?utf-8?B?dEowK2w2S09NU25nY2drNmZiV3FtdU1FKzhKZE5qS2dHR3ZkREEvSGVqcFJQ?=
 =?utf-8?B?azQrcUVrZkdWbWExT0ZuN1ZTSmd1eXNyTUFrWUszVW5ZZndrcTJYaXI5Vndk?=
 =?utf-8?B?YURha2NuVjM5S05rZDVmczZabHVoaEVEVXlHZTJwMXI3RXZFTmpGcG5ibld5?=
 =?utf-8?B?TEhLempVMFVZUHR0aW1hdW9zZm9RazhGTUJSdStkaG90Mnd6RXN2dlpGb202?=
 =?utf-8?B?R0s4dHVQQVhhTzZENkk5WkQxbFdPNTVrWDducThuMVhvdVJDaXIvdi80RXdr?=
 =?utf-8?B?NWNsS0dSQVhpczhBU1lzV3BwU1dxVWIwY29yMGJwVW4xbXM5QmdUdi9jRDZz?=
 =?utf-8?B?NExjc3dyUTRVUG9FU3FvaE1KWXoxWHhlT21GV2xjN0YxTHc2ZU5ZWUxFcUlM?=
 =?utf-8?B?Y1BSdS9xOEV3ampSSWNnZVU4NjlVUEk3UUFrcGFYaTNjSVdtUHBqdU1zbnY0?=
 =?utf-8?B?aThGSUtMUCtVekYvMkxENlhVTDRoVi9FV0dhVnhtMnp5d0lhNkRvcGM5bmRU?=
 =?utf-8?B?L3YzNGw2Mnh6VHoxejNIZk1hTjE5UFc5RSt3L3g1TWluemFkSjhvSWdHeG14?=
 =?utf-8?B?bGpyakxrZnMrNEpnOXhFT3h6NHBnQ3kxazF0Z3pDOEtTZVRuMVUveXdoN00r?=
 =?utf-8?B?bUxXQzRWQW96ZW0wSkk3RDUzU0ZFUjByWVJjYzRETDJZL0o2QWlXSk5yeWFE?=
 =?utf-8?B?RTd4RTg1TVZyaUNNMUZQclR1dDYrSUIwbzJySU5lQUxiUjQ3aGdXRWdveXBR?=
 =?utf-8?B?STBWSWFZWVBzQlc0bjhpSFJDUUVMOTA3U29uc3hMaUpwZ09RVjlsdnN6SGZY?=
 =?utf-8?B?ejZRbjl0aFFuMmdYeXR1T3E1Y1A1c0I3cTRTOUlXVml3WTFBY0lSbllkbnpX?=
 =?utf-8?B?ZlM4MytDcFNLTm0yL3YzU1lkN28xZCtXYmJYYmp3ZnhVZXNPUVh1WjNHOEVX?=
 =?utf-8?B?SjkrVUNNd1grZ1RYS3pRbVpyVUlwMzBIdGxiaVRlRWx0K2lVd0xHM2tBV0xv?=
 =?utf-8?B?RFFXN3pWQ3RlTGY2U2R3eVNQam5Zazg2NlJ3NExkSU9scHVwUG92OTk1Wkkz?=
 =?utf-8?B?aUNxbCtrR1Y0MzY1aHptVnN4aTg3aTRIeit6U0huRGx4YlFXV2dudWhoR0RC?=
 =?utf-8?B?MkYwcWFOUmhoaXErYmF0QzA3d2JNM094NlpxWTluMVNrUnlYNzVOOFF5RGQr?=
 =?utf-8?B?U25GZGlndzJreFVVUFRFMnRValBhTWtxUmdBN3hKMUNaSVY5Tnk0VXY0TnNU?=
 =?utf-8?B?T2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eb795d03-611f-42a6-f619-08db9ceec03e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 17:49:04.5857
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VnIvwWJ7VDhNcCmEo6Ok6b5Lli8DXoPKH7qMKUX9VESyiPIFFekL8wP4Kk/vGRiqypA+2/fwGg3ZjTyJrIK3A52tjYP/QgmJAf27hbP9rmg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5317
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 8/8/2023 2:16 AM, Ilpo Järvinen wrote:
> Benchmark command must be the last argument because it consumes all the
> remaining arguments but help misleadingly shows it as the first
> argument. The benchmark command is also shown in quotes but it does not
> match with the code.
> 
> Correct -b argument place in the help message and remove the quotes.
> Tweak also how the options are presented by using ... notation.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  tools/testing/selftests/resctrl/resctrl_tests.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index eef9e02516ad..559868b16079 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -52,7 +52,7 @@ int get_vendor(void)
>  
>  static void cmd_help(void)
>  {
> -	printf("usage: resctrl_tests [-h] [-b \"benchmark_cmd [options]\"] [-t test list] [-n no_of_bits]\n");
> +	printf("usage: resctrl_tests [-h] [-t test list] [-n no_of_bits] [-b benchmark_cmd [option]...]\n");
>  	printf("\t-b benchmark_cmd [options]: run specified benchmark for MBM, MBA and CMT\n");

Considering it was documented goal of patch to use "..." notation, should
it be done consistently by changing above line also?

>  	printf("\t   default benchmark is builtin fill_buf\n");
>  	printf("\t-t test list: run tests specified in the test list, ");

Reinette