Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <0423ff9f-f783-0986-9867-7862560b8c59@gmx.de>
Date:   Tue, 15 Aug 2023 23:34:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2] fbcon: mark fbcon_registered_fb static
Content-Language: en-US
To:     Min-Hua Chen <minhuadotchen@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230804113237.51653-1-minhuadotchen@gmail.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20230804113237.51653-1-minhuadotchen@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:YYDjm/h8/2Y=;3WRuj6txlGau774QBVBT7QGpwov
 3XOZzXwjg6UKeMnjjyqwCu6jG926bKJb38+SmWGjyh/KKA66fWYQ6YLaHkXd2XskzR5JX6U76
 nlvB0B7Bk+yr62EgrpY+e+B4K4mZ7SlYuBng2NUxFeB1ZJ2cvzB4lDDGLn+dM0sugwpk83ZFF
 SYl9KeYFjfauGPLsACx1djLIs5jo4APj0Oeorf0Bl1P4A/jRQUEDpCDdj8qD4KqyVnrYdI+wD
 UIQa1pqNZ6ckRbHRzg+o2hpdZZKood2LBYrANADalF43Ufos/G0sEHJ5Wjz70H4aREDzulUW4
 umzWwV4Q5mSBqG+5etyyS4danQ9bQZ3ZgLWfo+lS/Y1oZsgLPQbxduDVHLhJcDQWLIANtyytp
 278aog6uk+XtlAWdXGRe3xCdph6AScEbCQA5IkT5Ig6ln9gKSzPdqJpm71lFAQL3gTghNbgGy
 je+VAZPbxXr+cM7VBQVEY3tD1UxtU80yPHHVY0BSfCe0bP7lImLqHkLdDb29LVe0Egtq+pLDt
 qElaUD5g7YUX3VPXzY0cjMA4aX0aCMPDX7L3hBZk2b374GvqQ4ZlMkar4FOClLcNdAXJor8Rj
 PxopP/M+d1/pwYNTjpNH0NHRqotLxnyuBEmIgqMKYqUL0TfYIs5xMHfwXTwe4LS644B4fkOtG
 V1Uqk41JE+rz+ysPQi5w3zADud8JSRr9JE/Oa2It9f7InYGP4/9lljPIKXKPEYCVBniHJmRyT
 v7fD7sNBJ7ev5lepSJBF6y04wch/csBvfATMmYnWVr9HmaPByairjWfaiI8gJAs2qarUhT14h
 XOecrnad+ybtDljXsSUzbWpsE0r0hgkqssZ3Q5oILv/Hrmnr22VbzskD3zlObI7DhE6Rn0uoJ
 WoUstQ7i0ndfLh0t3w16SMj04jW4xHjLmj4TnrKetgcopoLObFZjTm+CBlrBqGwhaIr1tWHVJ
 mtXO7VMMTBdKenfgdTIyaeGEyfY=
Precedence: bulk

On 8/4/23 13:32, Min-Hua Chen wrote:
> Mark fbcon_registered_fb, and fbcon_num_registered_fb static
> to fix the following sparse warnings:
>
> drivers/video/fbdev/core/fbcon.c:105:16: sparse: warning: symbol 'fbcon_=
registered_fb' was not declared. Should it be static?
> drivers/video/fbdev/core/fbcon.c:106:5: sparse: warning: symbol 'fbcon_n=
um_registered_fb' was not declared. Should it be static?
>
> No functional change intended.
>
> Cc: Helge Deller <deller@gmx.de>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>

applied to the for-next-6.6 branch.

Thanks,
Helge


>
> ---
>
> change since v1:
> 1. registered_fb and num_registered_fb are still used in drivers/staging=
/olpc_dcon,
> so do keep them as-is.
> 2. change the subject to fbcon: mark fbcon_registered_fb static
> ---
>   drivers/video/fbdev/core/fbcon.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core=
/fbcon.c
> index 887fad44e7ec..976900d6893c 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -102,8 +102,8 @@ enum {
>
>   static struct fbcon_display fb_display[MAX_NR_CONSOLES];
>
> -struct fb_info *fbcon_registered_fb[FB_MAX];
> -int fbcon_num_registered_fb;
> +static struct fb_info *fbcon_registered_fb[FB_MAX];
> +static int fbcon_num_registered_fb;
>
>   #define fbcon_for_each_registered_fb(i)		\
>   	for (i =3D 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++)		\