Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <a7f0016e-d51d-1e3a-d470-e6dcc18228e7@intel.com>
Date:   Thu, 17 Aug 2023 11:51:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v3] dmaengine: idxd: Remove unused declarations
Content-Language: en-US
To:     Yue Haibing <yuehaibing@huawei.com>, <dave.jiang@intel.com>,
        <vkoul@kernel.org>
CC:     <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230817114135.50264-1-yuehaibing@huawei.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20230817114135.50264-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QW9mVjVxeW4vL1NCSi8wN1JhSXRkMG5kQ0NmcThqR2xhOXRQRXpOaHZyYzM4?=
 =?utf-8?B?ZEZFcUw5eVRwUVZTa0FpS2JJQVluTHdFU09saWsxajc2TUtSaWdWNDQ5UlFH?=
 =?utf-8?B?cW1yYTlKamx0dHRSdkZFNzZMOFE5d2JSZ003V3VHTnd3RXA5ckREemlibTVl?=
 =?utf-8?B?bHFWSUxwUFFNU1RmVEdnZ21mdGgwdENGTEFEUUFpKzh5L2tITWVtcGFoZEw1?=
 =?utf-8?B?dHF5YVNxaTJiSmNYeVlzTWpPYzRGMElOOFdsd012ZGx0Y2xFeTE5S3g2QSts?=
 =?utf-8?B?c1RsSWtMSmNIcDBUaDV3T3U3S0pybWQzc05CR2g5S2I3UUJkS0o2VFNWN2NU?=
 =?utf-8?B?WWpBLzlnbys1bjRyV0xaeWJ3MmZFQ284NzIrUGx1WDlhNm9hNTNxUjJMRTNh?=
 =?utf-8?B?NE01ZXUxQ2NjMWxTa1p0dGNTUXpTRUJ2Ry9oOXVlcDROcllNYld0S2t5bFYy?=
 =?utf-8?B?b0YyYkthbkEyRUFmcmdJWW9zVHQxa01OT3crYy9SaEIyNVJlQzJpUnFIRUZi?=
 =?utf-8?B?YVJ1WDJEd3AvQjBCUHhTdVViK0dhaUV0MG0rVkJISnc2RVJZMXNuMFF3UG43?=
 =?utf-8?B?Y25Ib3RXUXdDVmxpYURNWmFqV0VKb256NlpSeFMra0NTV3NFY3VTL2ZLb293?=
 =?utf-8?B?ckUxQmVqRE1BYWF0UDNzaGNEOXdkMEZjbVpEM0ZHajFqck9pbEtwMVJ4bXJt?=
 =?utf-8?B?MWhCSzZ0ZkI5aFFuTTl3YjdGNzdCMkVaNjJsazJncUhOc3ZpMnMvOTJTV1ZZ?=
 =?utf-8?B?Mmt3SGlUUk9oVFBHSzNsNWJQZXQ5RXR3bXFaNk1wK2VrK2NiNUxRZFJzdDFK?=
 =?utf-8?B?QkhSTS9mdjN5VkhOTUluMmVFWk5xRUV3dlB2SEFPZlFBaXFlUGVvZjhSVEVV?=
 =?utf-8?B?UFRFS0lyYkkwbnpacDBRQWtYemlGeDIzcmMwNW9BcHlYcDFhMFlVWUJFU0Jh?=
 =?utf-8?B?SVBNOFlzaUs2QUtCcmFsMW5OMGw5U29VcDNBR2xNTnJaYURvNlc0UHBuc09Q?=
 =?utf-8?B?Y3djTlVUaHRKamVaY01sbExFVlJJL3MzSjgyRVFQb2dwL1VJb3pvd0FuTFhr?=
 =?utf-8?B?NHQyWjB4UXdKSHhOL0RBZHYvWWhNZ3o5TGYzRnBZdXpUbS9WeHJtMzg1SE5Q?=
 =?utf-8?B?S1Vnc1NHMHZiK3plNnNLYUpxMlJVOWxTQzBKaWN5ZjY5ZkcycFltaTU3NkRu?=
 =?utf-8?B?VTZ6K1JtMDlSOGFvZ1diT3B0aUVUSzVEMmhVN2NxeHZnZGVsRElRekJWR2pO?=
 =?utf-8?B?bDFaVFBnR29tZHh4dHZBUFFEZDJLU3lTS0NoRmtxd3YybzB6UEY4MERQVUx1?=
 =?utf-8?B?TTFNczJwNk1icmc4OG9ybm80QmdDRStVbG9tTHN6MEtWOGlqbjRZdVBVTnVW?=
 =?utf-8?B?RmdvU095Ni9BQ01HNW91ZUlJOTZPcmtGWTU0Z0d2SEdKUktYdVFjUE81OWVt?=
 =?utf-8?B?SkZkMVZvWGJOSzRmNllXRDc2Y1diZXB6QVZqblhzTm9CMFFtYk4rY29kU0dr?=
 =?utf-8?B?R1JyaXE0dG90ZERud2FNWXdvVmQvNklBOXNBRmZkOSt1UFR6d0tTTFhiWWN4?=
 =?utf-8?B?SytBNEp4bmRGZlVVMDlFNUhpa1FzdUgrSXgxWDRPQksxVlpZYzJIcWVhRm92?=
 =?utf-8?B?c1JnMlU0cUtTd0tTL1JNejhnS254Z2xkSER6UUMxZFNUUkNzUmZ0S3FaU1Vj?=
 =?utf-8?B?LzBrUXRNUDVxeUd5VnlmQlhWR2s0cnJUWEdNdG9xMkZyZ3AwK1kzeGQ0b1hC?=
 =?utf-8?B?KzB4cEExcm9QYjN1TDhZQXFKd3BKNUtrcUNoZ243elkyWlJUSnZpQzl2cjN6?=
 =?utf-8?B?bXBhcVR6MG1NcmpZMDdTRjdBN2s2OW00UmJ6STEzTzZxc2dwNmJzSUJwekVF?=
 =?utf-8?B?SkFYZmFCeFo1K3ZnTHBPSDQrOUdFcDNJRHNkTUdRSkozZ05VL0dscnNiM3FK?=
 =?utf-8?B?Z0ZWMWZXU0grUDkzL1N6b1I3Uk5Nc1pwRGxQdzA1WjROZFo0YnhUOW5pS3pF?=
 =?utf-8?B?S3JPb0tUVG5PK3NzTS9KK1V0V1lNZFV4OHl3dXA3ZWNMYlBYNlIxYk5ZVEQ1?=
 =?utf-8?B?WDVqUnEzMERlbUNhMGJVVEhxUHN1L2VBbno0VGpPRzhXa1loQy9XMXEvdGJG?=
 =?utf-8?Q?opgeKNfwsa68R+9ns7r902JlM?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bf963425-a54d-4461-3107-08db9f52e36f
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2023 18:50:55.7412
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6E6ytFj80G7jHHIM2vZJge5ZyUdAynZt91aTF4OhbERq4XAbh9lIvlnXB6of+q3++TEQpvB9XI8XKmK7wHLRcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6239
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/17/23 04:41, Yue Haibing wrote:
> Commit c05257b5600b ("dmanegine: idxd: open code the dsa_drv registration")
> removed idxd_{un}register_driver() definitions but not the declarations.
> Commit 034b3290ba25 ("dmaengine: idxd: create idxd_device sub-driver")
> declared idxd_{un}register_idxd_drv() but never implemented it.
> Commit 8f47d1a5e545 ("dmaengine: idxd: connect idxd to dmaengine
> subsystem") declared idxd_parse_completion_status() but never implemented
> it.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua