Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <610023b1-a7c4-cc16-a912-aa22fb42c9e8@intel.com>
Date:   Mon, 14 Aug 2023 10:49:54 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.14.0
Subject: Re: [PATCH 4/7] selftests/resctrl: Simplify span lifetime
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Shuah Khan <skhan@linuxfoundation.org>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20230808091625.12760-1-ilpo.jarvinen@linux.intel.com>
 <20230808091625.12760-5-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230808091625.12760-5-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0F2bFdWcmZXdlFja1BMcWVpdGdmNFZMSGxKZk0ycmxiRHJUNXRyWWh6ajBH?=
 =?utf-8?B?SXdSQUtJVWZscmV3WUNpQzBxMzJwcmk0TUNzbng2WVppTTZDbis2Y3hQZ2Vk?=
 =?utf-8?B?SjYrTTAwaExyRGVLQ3NpUEtjT2RzQUN4VitNK0psRXdZOSt6SDd2d3FpVTU0?=
 =?utf-8?B?RUdUWlA0UGwrYW9mcktRMzZzQnZFRFlCbUlEQnd4YjNRSEwrQWpYOW5aSjdi?=
 =?utf-8?B?QjhrYVpFeGY2SlFtTTE0eXRnNjhpN3pZWXdRa1k3Z0tGQkFEQTBaTkYzV1hC?=
 =?utf-8?B?NXBybklDbEE2RjZPZnBHL0NLTGd0VjcyOUgrdVhKQWVSNnBOZ28wcDN4a0dr?=
 =?utf-8?B?NklJbGNmZExlSngxL3BGNjNrTk03dlp0RXQvODlUOHRQbU1JRUtlSXR2REhJ?=
 =?utf-8?B?YUZXVndYL1VUWnNSUHIzODAxQ2hCeXNhNklBdGxlQzJJdlRMaHhmNHBmSjBG?=
 =?utf-8?B?a2ZaVENkcHFXYmhUQ0ZUdmRCdHRaUjNDVVk3M3VsNDQvcndXUUxETC9Kb0Yr?=
 =?utf-8?B?cCt0elovZnBWcVdtaTY1NlNCZ3JyQUN0VS95RW1rYlpBdzRNa1BLT3pCUGFq?=
 =?utf-8?B?VlpXUjhxbTFrajg4TTg4MFVFeWk2U01IVTVQVnkrOGxnS29hZVpVQTVKOVdn?=
 =?utf-8?B?WVp6bHo0R1lZUGNpRDhDM25HV2Q4L0huOXJmaE1yOXFLWTlNZkhWRENKL05C?=
 =?utf-8?B?Qm1zTDV3SHRkb3o3NUMwUTREWWw5V0UrSnRISndTSDlnTWtPMFNhbHA2UjM2?=
 =?utf-8?B?SzFTRStGWVc3aHJTWTdzbzM3Tkd3cG02eWtqZHZkVkl0NUFTNnhYT0dTWDJp?=
 =?utf-8?B?UTBzUjJRWE41OTRzQlFtYVpRQ0Jhc0hQTnhFdDJOVDhHTkdCVnNJSWZzOGl2?=
 =?utf-8?B?WGZFVWJZaWJaVHBHMlR0K1JGVk9pQlc1ZlBDTXNQY0lhTVpSbWdiNTNRalJw?=
 =?utf-8?B?dXQ4a2E4Y0tqTVl4SC9DbHRqNHNqK3JFaVJZRGplMUlYVmVndVE5VWNHU3h6?=
 =?utf-8?B?ampTbTFkOVJadTJxYUxZZVBJSVZpUjVkQXNXcThwekJObzFrNEtoTHUyNkR2?=
 =?utf-8?B?TnRzUWdITWJGZEY5eDg1SlMvcWpyV0ZwN3BYZjc2ZXl0MDZDdXZvMWtCV3lH?=
 =?utf-8?B?cFpyRTBGOWpyN2hVdzBGaGhYWmU3YU9pMG5TdWJmMURLb0MxN3FoV1NnNFBq?=
 =?utf-8?B?YTNFUmV0ZU1GNWdlWXJPd0NCR0Vjb01pR0krekZ6dFBSaEJrU01oSUZNSG1r?=
 =?utf-8?B?MUF6UkZrdGpKaUhhMkhGT2xyeUxJRDV6Q1RNbEJ0RHJrOHRqZXBUOS9INnNq?=
 =?utf-8?B?ajBwZ2MyVUFnV1hnS1hXekxlUjlCSVFpVEJVVzE3VlMwd3JEOVN5MzQwTnc3?=
 =?utf-8?B?M1VBVDNQQWFvUXVjazcvQXpiVzA0MjFFYzZRR2NrZHVWRmdBaURvd3B3Nkw4?=
 =?utf-8?B?NmdyTVdSN0xMa2ltMk5lOURwSHA0TTlvM2l6Wk5mc0haMVBTYVQ0ZmNkOUFH?=
 =?utf-8?B?RHJSK25RNFUxV1lOaUxtQ2dRTStBNS9hTWtvU1lETlZxRG5FZ3JKTE96T0M2?=
 =?utf-8?B?eXQvSFFUSW4zRzR1b0VFai9yQ0pRNGZSbTkyOU9iUUxlNFBsbGVUNjBZM1Zi?=
 =?utf-8?B?Zm5WVU5EWlZLWnBQTTdqa2dXOFM3eklZTlJmdVpBclkzOGFvNXN4cG1uTjhw?=
 =?utf-8?B?SHI1QTdEY2dGTDkxemdndFZUTDVENjF2YnZpWXlaYzJxOWZKVjFhbktYdU9B?=
 =?utf-8?B?SjkwYjdzYnpWT3NqQXlTamRKbjRHb2F6UDlZRjVtN2lzMjFQZDQvU2VxcjMw?=
 =?utf-8?B?UTNpeC9KUFJuVGIrSG82R1pUZHdsbFdQSXdCWEM3UWE4VUcvczFlKzdROXBa?=
 =?utf-8?B?R0U1OVI1QXFuajUyZ1lSS2FTUW1xeFVlWVFwbTlGeCszaUlnRzN0N1ZMSzQ1?=
 =?utf-8?B?eWNMeUh3enlONHJxUWNuN0xrNWtqVDFTcVNVTUlKbDZxcUdkMEwvanBhSEtt?=
 =?utf-8?B?SGVhS21OTG5jWmxNZ2N4dkoxVytYYWU4U3FrWkxzTzBTZGdlVFlielhlbWdC?=
 =?utf-8?B?Y0l2R0RkdEN0MFNmU0U5VE84L1o0OHpqOGJhZGZzYmxwMEJQd1VDREtaWWZH?=
 =?utf-8?B?SG9RZU1qeldRSDlPVHFkbnRsMXRmb3p3RU4zaUlxak1vNGRuc3k1WWpFa09v?=
 =?utf-8?B?RXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ccd2714f-64df-4c4b-b090-08db9ceedf8a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 17:49:57.0983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8pQg1IJu30+KZuccO45Z2/U7cmR+l1oxrLU6V89GbuTrG6w1WxGS/X3ijb4JL1w6xmHflzUZJEXYY41MxtvrAbOHX813LCtpYZkGONOB46c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5317
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 8/8/2023 2:16 AM, Ilpo Järvinen wrote:
> struct resctrl_val_param contains span member. resctrl_val(), however,
> never uses it because the value of span is embedded into the default
> benchmark command and parsed from it by run_benchmark().
> 
> Remove span from resctrl_val_param. Provide DEFAULT_SPAN for the code
> that needs it. CMT and CAT tests communicate span that is different
> from the DEFAULT_SPAN between their internal functions which is
> converted into passing it directly as a parameter.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

If I understand correctly the custom benchmark has always been
required to operate on the same span as the default benchmark in
order for the results to be measured accurately.

Thank you for eliminating unnecessary code.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette