Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 16 Aug 2023 15:31:57 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Will Deacon <will@kernel.org>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        David Spickett <David.Spickett@arm.com>
Subject: Re: [PATCH] arm64/ptrace: Ensure that the task sees ZT writes on
 first use
Message-ID: <b903e4ce-83c9-4fa0-ac95-8378c436d846@sirena.org.uk>
References: <20230814-arm64-zt-ptrace-first-use-v1-1-fc8e8022140f@kernel.org>
 <20230816142219.GA13526@willie-the-truck>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="s4rNUHRjF2KWGoco"
Content-Disposition: inline
In-Reply-To: <20230816142219.GA13526@willie-the-truck>
Precedence: bulk


--s4rNUHRjF2KWGoco
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 16, 2023 at 03:22:19PM +0100, Will Deacon wrote:
> On Mon, Aug 14, 2023 at 10:27:51PM +0100, Mark Brown wrote:

> > @@ -1182,6 +1187,8 @@ static int zt_set(struct task_struct *target,
> >  	if (ret =3D=3D 0)
> >  		target->thread.svcr |=3D SVCR_ZA_MASK;
> > =20
> > +	set_tsk_thread_flag(target, TIF_SME);

> Hmm, this is now weirdly inconsistent with za_set(), which doesn't touch
> the thread flag unless the regset copy succeeds. Is that intentional?

Not particularly, it's just a product of the more complex parsing that
ZA needs due to the variable size and optional payload.  Either way is
fine so long as we allocated the storage but it would be better if they
were consistent, I'll update this to match what ZA does.

--s4rNUHRjF2KWGoco
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTc3dwACgkQJNaLcl1U
h9AtVgf9HS5c0fIU8LG6aCTVzGi9dcQfpW6cnpakre3AJZCpNHjXZpBOM0Zg6F2A
4ZkPLxjQHzc3NtHxV1cmUq2L1+wGGRdQGQAXRFioQ6wrDPCepA9QYTG+gsn6k2Ba
9Ov7Vtrj0aCCTaWYDlSxECVSFehAnIYmiWKrDiba4FC4m1/uk//9yh5gEmO3Z1P/
YcMC46CH7WQKlDSTJmzgJeeDc7osxd/o0VA34Prt7/POCpmP8F2VrCnQXbL9tQpG
9zXadPU+Hvb8ice3WEU/Uc0z50XIIg/lyfob4Q+XfJL46LM+L+voA2Ae4RhPT0AV
+tRQlAiDPBoOZd3/xbKRTuEuUp40+A==
=Hdmf
-----END PGP SIGNATURE-----

--s4rNUHRjF2KWGoco--