Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757435AbXKDLTv (ORCPT ); Sun, 4 Nov 2007 06:19:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759155AbXKDLTl (ORCPT ); Sun, 4 Nov 2007 06:19:41 -0500 Received: from extu-mxob-1.symantec.com ([216.10.194.28]:46751 "EHLO extu-mxob-1.symantec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759143AbXKDLTk (ORCPT ); Sun, 4 Nov 2007 06:19:40 -0500 Date: Sun, 4 Nov 2007 11:18:38 +0000 (GMT) From: Hugh Dickins X-X-Sender: hugh@blonde.wat.veritas.com To: Christoph Lameter cc: =?ISO-8859-1?Q?Oliv=E9r_Pint=E9r?= , Linus Torvalds , Andrew Morton , Willy Tarreau , linux-kernel@vger.kernel.org, stable@kernel.org Subject: Re: [PATCH 1/2] slub: fix leakage In-Reply-To: Message-ID: References: <6101e8c40711031027x3f946b28p324dadeab7c1b2c3@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1392 Lines: 33 On Sat, 3 Nov 2007, Christoph Lameter wrote: > On Sat, 3 Nov 2007, Hugh Dickins wrote: > > > Neither of us has yet posted a correct patch which applies to 2.6.23 > > and 2.6.22. I'm testing your 2.6.24-rc patch overnight, and if that's > > fine then one of us will post the version for -stable. I thought I'd > > better leave that to you, after I've reported back. > > Ok. That testing went fine, as you'd expect. Your diffstat is certainly nicer than mine (corrected for SlabDebug) would be. I expect you'll go ahead with yours. But I remain slightly uneasy about it: I do think your original instinct, in putting in the code you're now removing, was good. In a low memory situation, when several tasks pile up to allocate the same resource, we'd usually free back all but the first, rather than depleting free memory even more than necessary. That you were doing before, now you take the simpler way out and don't bother. I've no evidence that this is a significant issue: just mention it in case it gives you second thoughts e.g. was there a concrete scenario, other than instinct, which led you to put in that code originally? Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/