Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 18 Aug 2023 12:24:15 +0100
From:   Lee Jones <lee@kernel.org>
To:     "Wenkai.Chung" <Wenkai.Chung@advantech.com.tw>
Cc:     "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
        "Susi.Driver" <Susi.Driver@advantech.com>
Subject: Re: [PATCH] Add a mfd driver to support Advantech EIO-IS200 series
 EC.
Message-ID: <20230818112415.GU986605@google.com>
References: <20230727053655.92525-1-wenkai.chung@advantech.com.tw>
 <ebc6d86e627242a785f75f88623108c6@advantech.com.tw>
 <20230818112239.GT986605@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230818112239.GT986605@google.com>
Precedence: bulk

Also, this patch doesn't appear to be on lore.kernel.org.

Please make sure the email address and formatting for LKML is correct.

The formatting for it in your recipients headers look odd.

On Fri, 18 Aug 2023, Lee Jones wrote:

> With respect to the subject, please use this command for examples:
> 
>   git log --oneline -- drivers/mfd
> 
> On Thu, 27 Jul 2023, Wenkai.Chung wrote:
> 
> > Add a mfd driver to support Advantech EIO-IS200 series EC.
> 
> Please drop all references to "mfd".  It's not a real thing.
> 
> Please tell us all about your driver here.  A one line description is
> not appropriate for a 600 line commit.
> 
> > Signed-off-by: wenkai.chung <wenkai.chung@advantech.com.tw>
> > ---
> >  drivers/mfd/Kconfig         |  13 +
> >  drivers/mfd/Makefile        |   1 +
> >  drivers/mfd/eiois200.h      | 146 +++++++++++
> >  drivers/mfd/eiois200_core.c | 496 ++++++++++++++++++++++++++++++++++++
> >  4 files changed, 656 insertions(+)
> >  create mode 100644 drivers/mfd/eiois200.h  create mode 100644 drivers/mfd/eiois200_core.c


-- 
Lee Jones [李琼斯]