Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 16 Aug 2023 15:21:08 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Nils Tonnaett <ntonnatt@ccrma.Stanford.EDU>
cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rahul Rameshbabu <sergeantsagara@protonmail.com>
Subject: Re: [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple
 keyboards
In-Reply-To: <20230815201959.17569-1-ntonnatt@ccrma.stanford.edu>
Message-ID: <nycvar.YFH.7.76.2308161521020.14207@cbobk.fhfr.pm>
References: <20230811202932.30413-1-ntonnatt@ccrma.stanford.edu> <20230815201959.17569-1-ntonnatt@ccrma.stanford.edu>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 15 Aug 2023, Nils Tonnaett wrote:

> Powzan keyboards KB750 and KB770 identify as
> "Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list
> of non-apple keyboards fixes function keys for these models.
> 
> Signed-off-by: Nils Tonnaett <ntonnatt@ccrma.stanford.edu>
> ---
> V1 -> V2:
> 	- Start commit message subject with HID: apple: instead of hid:
> 	- Comma terminate last member of array
> 
>  drivers/hid/hid-apple.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index d7b932925730..3ca45975c686 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = {
>  	{ "SONiX USB DEVICE" },
>  	{ "Keychron" },
>  	{ "AONE" },
> -	{ "GANSS" }
> +	{ "GANSS" },
> +	{ "Hailuck" },
>  };

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs