Received: by 2002:a05:7412:bc1a:b0:d7:7d3a:4fe2 with SMTP id ki26csp966971rdb; Sun, 20 Aug 2023 10:36:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH9kRTL5OPifmBqt6HRNF5MglkYWxRZkDYOciZDAu1D/bj7UHHu0teRf646666bMhC9rVeP X-Received: by 2002:a05:6870:a447:b0:1bb:8ab6:6642 with SMTP id n7-20020a056870a44700b001bb8ab66642mr6525566oal.8.1692553006090; Sun, 20 Aug 2023 10:36:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692553006; cv=none; d=google.com; s=arc-20160816; b=S155FNNuVyhPVCuDSie3gTY0A9aEZUdG0nvy7J0ARFHHk4sE2a65W87wnBU9BUSlJX JZdcOZ56IlR2LCjRNA52rtwU9XJgGhgsQI3KEXbOPjWtO2VugCCpXZ6WxE/JT1z23O3Y tQETyO+t5Lyjv2NHnSppQf670JenmHMJRQgiMLmwpYvU6mqXnfliKAcSfTOkXKVAzE0P aLnDiqVNXkTU9ImKrWZn7Ik80yd9DR352s0CY79/kNXnP3FfMacsXxAjiPkQAPAAhFKU Gw5OIxpnOQrddBpKbec8StrVluTdFFtL90nHbfIYdf0ujQ34vQhGAeJ41OpTR7mjbcHD 6mig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vdKfE//kPyeau6sUrJIwQjBn/zIMIwtztMWftZHIXus=; fh=k7XzfpyqnKqnwxpqVF0NftrWa2FIpeAcHVbykF5xarA=; b=mJXeortMoRTGL7vWcrdNvAgTxXBZV+8qTYaJ3jeDV7c6qkY5PTrERldGpytHLAX457 KUcOGlF81A0Dy0RngpFJy34JuZiLOd6say40QMVwI5kZ8/oLiLkyEo8EJBTIE1ykesHw XVa+ek8qCPP6elZO5vTpdZmW9xh6lgrsT/gZDkK1gQGEv4kjETGe3DfO/BgCbHy7sPxk aSb3DkB2+/G+XuyjtKYjPgz9F0+zFYQnclOFw9aK8ELhYjoSPNzWPMkPItOvfvOxUF/x hzRYnm6ZoEHBmeVVNrV5dQ8mWeKl6OUA0/WhEthfbJFEe9UsVQWNngiue/9EjqdZ/Zv5 BNIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nWho2sN2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id s90-20020a17090a2f6300b0025bb4a1c12esi5685611pjd.148.2023.08.20.10.36.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Aug 2023 10:36:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nWho2sN2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1E66D36EC7D; Sat, 19 Aug 2023 12:09:16 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244256AbjHPK4M (ORCPT + 99 others); Wed, 16 Aug 2023 06:56:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244002AbjHPKzl (ORCPT ); Wed, 16 Aug 2023 06:55:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B3A81984; Wed, 16 Aug 2023 03:55:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 281A06555F; Wed, 16 Aug 2023 10:55:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7381DC433C9; Wed, 16 Aug 2023 10:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692183339; bh=Y8jrcsirIkNz5+yJ0roZSoi6QKBn7sM9JY7d66gE/H8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nWho2sN2qAh/5RsypM+m0TKtkt73PKKWl6h0liiAY3Q4ry4rRR7kk7wqPxJG8VL2S us+OiPmNypy9EmV0HMwTN0mz/+KS8c0IAI1HC5uapjZ1boINuv5NuHMWmx6d6+jmoC 3xwnogGnK1Vbeu5y4qiw/lOMl34E/mLtLDcjWLFtWuG2in3/OmzI/BzJ9SmKW7Z5vD OuhoXZFxYQcpKBe9W/0V2AfxL0WWqFDEv4wOVcOaUE6Nr7wBFBdZPVIYuw+NLhCCEL a6HSNI956p6eDtvtYqOX8Q5+sX6LahZO8bId10bMMQ+xiovyTvgXjN3UrxPFLAgcew 54W1tbse5r6wQ== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 04/10] tty: tty_buffer: warn if losing flags in __tty_insert_flip_string_flags() Date: Wed, 16 Aug 2023 12:55:24 +0200 Message-ID: <20230816105530.3335-5-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230816105530.3335-1-jirislaby@kernel.org> References: <20230816105530.3335-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org And add a WARN_ON_ONCE(need_flags) to make sure we are not losing flags in __tty_insert_flip_string_flags(). Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/tty_buffer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c index 94a88dc05a54..c101b4ab737e 100644 --- a/drivers/tty/tty_buffer.c +++ b/drivers/tty/tty_buffer.c @@ -325,6 +325,9 @@ int __tty_insert_flip_string_flags(struct tty_port *port, const u8 *chars, flags += space; } else if (tb->flags) { memset(flag_buf_ptr(tb, tb->used), flags[0], space); + } else { + /* tb->flags should be available once requested */ + WARN_ON_ONCE(need_flags); } tb->used += space; -- 2.41.0