Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 18 Aug 2023 19:54:22 -0700
From:   Bjorn Andersson <andersson@kernel.org>
To:     Jie Luo <quic_luoj@quicinc.com>
Cc:     agross@kernel.org, konrad.dybcio@linaro.org,
        mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        quic_srichara@quicinc.com
Subject: Re: [PATCH v4 3/4] clk: qcom: common: add _qcom_cc_really_probe
Message-ID: <4n3vqstyhknanmzx4swwjg4ueaqq2tbrxadnyrx3bchffyf7qr@yh4bik4rfsgm>
References: <20230815085205.9868-1-quic_luoj@quicinc.com>
 <20230815085205.9868-4-quic_luoj@quicinc.com>
 <2dcu7jjwd2bhjbzxrxbfif566nupznb5n4oadnqha4h45w2n2g@4uy2pxkj5bvj>
 <6ee2129b-04c6-4978-03d6-835e3a10e665@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6ee2129b-04c6-4978-03d6-835e3a10e665@quicinc.com>
Precedence: bulk

On Fri, Aug 18, 2023 at 04:35:52PM +0800, Jie Luo wrote:
> On 8/18/2023 11:14 AM, Bjorn Andersson wrote:
> > On Tue, Aug 15, 2023 at 04:52:04PM +0800, Luo Jie wrote:
[..]
> > > +int qcom_cc_really_probe(struct platform_device *pdev,
> > > +			 const struct qcom_cc_desc *desc, struct regmap *regmap)
> > 
> > Why do we want to keep this wrapper around?
> > 
> There are many existed clock controller drivers using this wrapper
> qcom_cc_really_probe, so i still keep this wrapper.
> 
> do we need to remove this wrapper and update the existed drivers to use
> _qcom_cc_really_probe?

Yes please. The additional API does not add value, but can be confusing,
so let's invest the extra time in fixing up all the drivers to keep the
interface clean.

Regards,
Bjorn