Received: by 2002:a05:7412:bc1a:b0:d7:7d3a:4fe2 with SMTP id ki26csp1002738rdb; Sun, 20 Aug 2023 12:20:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgzLOQg1N73DbX2V2RRhGxhVfRVbFoAikQLtpy1jXi9JQi7SyzRbq1FyF5BRsiGqWlsBPo X-Received: by 2002:a17:902:7293:b0:1bf:13fa:e75 with SMTP id d19-20020a170902729300b001bf13fa0e75mr4729637pll.51.1692559250935; Sun, 20 Aug 2023 12:20:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692559250; cv=none; d=google.com; s=arc-20160816; b=O6XXrRDxcX+35q+BwUTJuUIBiT/2K6LsCGJLGNQdKNwVKFsQG2itilMe1dFPp9bkg/ fACkdY71DUTPLgsCknvZGlL8qrSnzpoKxtG4wg0jw7ytLbEEYFCwh2fxrGlGp+CIXC3V 5znWGmnVAog6B+L9xyVQCrY09uGwmuLxFvmdkl/BYtCQjc4PnWq5xubPiHNtrU8IS/HM KNCmJI0vOHa8jv6BJyJGQ8fpNIkSeoppl3Su8skrRXGAwxGi9Z0aI0RM687ezhd4eGHV hxynZVVRq+1z5lCmK8tIu6d3wcBR52Ay+gRGCXL91iufxGs19gdp5Z9y24aA96+A6qS4 fYxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qqmcrIOgwT4P/m/Qo0pGRwGzeNac3H+8rfjS3Os1OQE=; fh=zUAAL0oq2+kA0nMRT5WSj9jrme2MlEZTDW5RK2mes1s=; b=mIReFE1bHcWySuXu/nl5KhksKteAevepP6+v4PoXWEll4WuzKZSo7OHBsI4JpFv0TK mf3bW3PKGoVKdb0ePgTUOMgGKjwEWw3jcpftV2p9pbNSDDC4hcFHm9DSXZiBoVlOsiHk QMqKYdChnwqd+ZQ+Pvl7H3IfbjSRyaoqc9Y1B4g7W58bw1QywYPlSM5m6uZjdemXEHy4 614ki9q1pzoA+0h6mULp3pG14WrKNwqoHxjVKVk+zo4+hKsT2Yl0pGkGBUaFKC69AoDY vALsegDaBuVa3NJOmrK47kARLF2FYZEqgkPjzbmevKGnMfDIKJ3dKiRZ+R9l8sac85Ud uFBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lVylwUoP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id u15-20020a1709026e0f00b001bbb175a81asi5477539plk.263.2023.08.20.12.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Aug 2023 12:20:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lVylwUoP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 259551D6D38; Sat, 19 Aug 2023 11:24:03 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232446AbjHNQ3p (ORCPT + 99 others); Mon, 14 Aug 2023 12:29:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231354AbjHNQ3R (ORCPT ); Mon, 14 Aug 2023 12:29:17 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ECCA10C0 for ; Mon, 14 Aug 2023 09:29:15 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3fe4a89e8c4so41430415e9.3 for ; Mon, 14 Aug 2023 09:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692030553; x=1692635353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qqmcrIOgwT4P/m/Qo0pGRwGzeNac3H+8rfjS3Os1OQE=; b=lVylwUoPcHqSk5F2gMB5oQ+4rf1xoT03hIVlQ0nH7RWxTPTXOkWaF2ArLEjE9/XfBv Pho1vZn21uCsBzinj09JqrBxvIronc/CDzjEkSty7NaIkpmitMUEOo0n6SylgVfCZaYE z1K3jIZBoRTpJzRtJm9H5lCoJnVsnqQZRAIBGh/NFWOFZ0GV9bsulpHVs+kSU+HK08e4 dMquqhPDuDaA0kKeCJOkAhXu7uMG9tdqSkQ/v9uuY1/WdnRlcMx1auWwyrRYS66xGh1b J/iizd1MNy4HaVGLAGtoVyMrnj9GY/VXJajzJ7LJabHP4Bq9ObiOmz/j7GiPVQ/GIqSG o6Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692030553; x=1692635353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qqmcrIOgwT4P/m/Qo0pGRwGzeNac3H+8rfjS3Os1OQE=; b=UxYm830COtoxr6EDCIkEWe9tTtm6bFF4jGTxjVF3YSakOwSJjbC5yJRXVzsna+6uDc c6yfjIrj3pDpiHG3+RCfUY9WGT4IA4qmirClPYyAjAaOmsPgfFZiWzsUM/yt7/J86++p 3uCRSp7M7pnVitPBnK/4wuM6w7rt6pXqgMbUJWjatQyXcXsj9BUGrxUL4GwqObuFeY83 pYAc3AA0ev9bSMvIg1u49MAHxM5mXFahh5WDAOht2ieUVVKeUTNvPJVMX/ZBqmpBlauB r7Ll8d/peVM/onSaxTWFEwB0KYsnwaG8rCjm+bXv9nCEoSbdh+D1fvEZOvegsvfDw1+u gejw== X-Gm-Message-State: AOJu0Yy5cUY9ybSkWU+grvE9AN2kf5O2927bgBaKGInV+l/GMtArLH9B j1qB0xGzMZA3DLkmJ11iooa91w== X-Received: by 2002:a05:600c:2207:b0:3fe:6199:939f with SMTP id z7-20020a05600c220700b003fe6199939fmr8238659wml.33.1692030553643; Mon, 14 Aug 2023 09:29:13 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id l14-20020a1c790e000000b003fc16ee2864sm14743475wme.48.2023.08.14.09.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 09:29:13 -0700 (PDT) From: Bryan O'Donoghue To: rfoss@kernel.org, todor.too@gmail.com, bryan.odonoghue@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 03/14] media: qcom: camss: Drop useless NULL assignment for ispif resources Date: Mon, 14 Aug 2023 17:28:56 +0100 Message-ID: <20230814162907.3878421-4-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230814162907.3878421-1-bryan.odonoghue@linaro.org> References: <20230814162907.3878421-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The NULL pointer assignement is a redundant step our compiler will initialize unpopulated fields as zero. We check for logical ! later on in the code as opposed to NULL anyway. Signed-off-by: Bryan O'Donoghue --- drivers/media/platform/qcom/camss/camss.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index d9e1672b74bd7..68eb45b2c0aaa 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -1729,14 +1729,12 @@ static const struct camss_resources sdm660_resources = { static const struct camss_resources sdm845_resources = { .csiphy_res = csiphy_res_845, .csid_res = csid_res_845, - .ispif_res = NULL, .vfe_res = vfe_res_845, }; static const struct camss_resources sm8250_resources = { .csiphy_res = csiphy_res_8250, .csid_res = csid_res_8250, - .ispif_res = NULL, .vfe_res = vfe_res_8250, }; -- 2.41.0