Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Aug 2023 09:29:58 +0800
From:   Leo Liang <ycliang@andestech.com>
To:     <chengming.zhou@linux.dev>
CC:     <mingo@redhat.com>, <peterz@infradead.org>,
        <juri.lelli@redhat.com>, <vincent.guittot@linaro.org>,
        <dietmar.eggemann@arm.com>, <rostedt@goodmis.org>,
        <bsegall@google.com>, <mgorman@suse.de>, <bristot@redhat.com>,
        <vschneid@redhat.com>, <zhouchengming@bytedance.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] sched/fair: Fix cfs_rq_is_decayed() on !SMP
Message-ID: <ZOK92_xLVsMmIEDE@swlinux02>
References: <ZN87UsqkWcFLDxea@swlinux02>
 <20230818132148.2237811-1-chengming.zhou@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230818132148.2237811-1-chengming.zhou@linux.dev>
User-Agent: Mutt/2.2.10 (e0e92c31) (2023-03-25)
Precedence: bulk

Hi Chengming,

On Fri, Aug 18, 2023 at 09:21:48PM +0800, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> We don't need to maintain per-queue leaf_cfs_rq_list on !SMP, since
> it's used for cfs_rq load tracking & balance on SMP.
> 
> But sched debug interface use it to print per-cfs_rq stats, which
> maybe better to change to use walk_tg_tree_from() instead.
> 
> This patch just fix the !SMP version cfs_rq_is_decayed(), so the
> per-queue leaf_cfs_rq_list is also maintained correctly on !SMP,
> to fix the warning in assert_list_leaf_cfs_rq().
> 
> Fixes: 0a00a354644e ("sched/fair: Delete useless condition in tg_unthrottle_up()")
> Reported-by: Leo Liang <ycliang@andestech.com>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>  kernel/sched/fair.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the quick patch!

Tested-by: Leo Yu-Chi Liang <ycliang@andestech.com>

Best regards,
Leo