Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758832AbXKDOMU (ORCPT ); Sun, 4 Nov 2007 09:12:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755000AbXKDOMI (ORCPT ); Sun, 4 Nov 2007 09:12:08 -0500 Received: from accolon.hansenpartnership.com ([64.109.89.108]:34238 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754614AbXKDOMG (ORCPT ); Sun, 4 Nov 2007 09:12:06 -0500 Subject: Re: [PATCH] sysfs: add filter function to groups From: James Bottomley To: Greg KH Cc: Stefan Richter , Kay Sievers , linux-scsi , linux-kernel In-Reply-To: <20071031172943.GA29492@kroah.com> References: <1193671019.3383.13.camel@localhost.localdomain> <1193676852.2655.21.camel@lov.site> <1193677071.3383.56.camel@localhost.localdomain> <47261F50.3050901@s5r6.in-berlin.de> <1193768743.3321.91.camel@localhost.localdomain> <20071031035506.GH14910@kroah.com> <1193841484.3411.8.camel@localhost.localdomain> <20071031172943.GA29492@kroah.com> Content-Type: text/plain Date: Sun, 04 Nov 2007 08:12:02 -0600 Message-Id: <1194185522.3434.7.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-4.fc7) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1135 Lines: 33 On Wed, 2007-10-31 at 10:29 -0700, Greg KH wrote: > On Wed, Oct 31, 2007 at 09:38:04AM -0500, James Bottomley wrote: > > On Tue, 2007-10-30 at 20:55 -0700, Greg KH wrote: > > > OSame problem here, if grp->is_visible is not set, sysfs_add_file() would > > > never be called, right? > > > > > > Other than the logic problem (I think), I have no issue with this idea > > > at all. Care to redo this so it works? > > > > It's a fair cop govenor ... new patch attached. > > Much better, thanks :) > > I have no problem with this, if you want to take this in your tree, > please do and feel free to add: > Signed-off-by: Greg Kroah-Hartman > > to it, or I can take it in mine. Actually, I think I have a use for it and the follow on patch (coming soon) to do attribute bitmaps in the SCSI tree, so I'd like to add your ack and take it through this tree. Thanks, James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/