Received: by 2002:a05:7412:1492:b0:e2:908c:2ebd with SMTP id s18csp44342rdh; Mon, 21 Aug 2023 07:17:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFKbXx3XyyZh1DzLAP+Fw7/MLuwYKQqgw9HscwKMYzOHU/38zQoPPfafS41BEROAdfVyiX X-Received: by 2002:a92:c245:0:b0:348:ba80:5a37 with SMTP id k5-20020a92c245000000b00348ba805a37mr10070187ilo.0.1692627464906; Mon, 21 Aug 2023 07:17:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692627464; cv=none; d=google.com; s=arc-20160816; b=XGfFtUaTyy5LkxFjlCxo60sdKHJ+r/Eom0bkXOw64V1F8hwNM7NUQfISLFaa114Q0j tJF6bi2yABesx3BHTB/S4/HP5bZfWnQ+JDSnIKoFW4BAcPMXCzt/UDVFQ+oz/yzxH/fJ AZMHYH/xcgj6B0dt3RLhckg2JA65oEEMCncwdpPsv/FlDw6ky36huQGU7cJSiGY+h0Y+ Gsbs2bTIHmypHjRxGbUs9UiZA1G9QTyrOADF6I0GplxQI3FtNisoTDBZcl5xIvZOt4LX 9nLDcPqqukXgZuHAj3La3lJK4V59OlCWzC8dI26n5U05fM5mgcoo38PWNP482oRkvwBh V3iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=sHeS+r4PLrfz908cD0ZmzQpvOOJGf2qgqJPjLQUBPl8=; fh=VGvfim7bJED5UlHfLRcNRsp9l78cMDdgWYfhXUZs5Z4=; b=k24HUkuWooarOp1kCclKQa4y3W/qIcunOZfMNnyZwnDP7YCQBR+qbxzsWtMakzZ0Sp aVhN1s068QVjmcYkP8fo6DUsRrVxR5ujUTzdTspg/vh2HVAwK67ijTiAZ0DlZn7UZ/sL QPsgrOSl3AxG2wiMkV8UOEavKI7LMPvPTpmm2YJDPYvKsa1pczBIed+4Y+qO1WNoMTza S+AsevV5hgrbDKm4cnUF3eU0LcP/VK/zwK2ALwW86ZLl+ca3SvdgCNjQri6HWrlF6W70 HPoJZ3zMPPDztdtv1X7lkHr/zgKPVNVAKVXKkn0qZFhgiTSix+9wM+uXtkuRkL0on77B el5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l192-20020a6391c9000000b005653cdf7118si6863927pge.401.2023.08.21.07.17.31; Mon, 21 Aug 2023 07:17:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234361AbjHUMUw (ORCPT + 99 others); Mon, 21 Aug 2023 08:20:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232733AbjHUMUv (ORCPT ); Mon, 21 Aug 2023 08:20:51 -0400 Received: from outbound-smtp29.blacknight.com (outbound-smtp29.blacknight.com [81.17.249.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE9DCC for ; Mon, 21 Aug 2023 05:20:48 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp29.blacknight.com (Postfix) with ESMTPS id 008A8BEFD9 for ; Mon, 21 Aug 2023 13:20:46 +0100 (IST) Received: (qmail 15072 invoked from network); 21 Aug 2023 12:20:46 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.20.191]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 Aug 2023 12:20:46 -0000 Date: Mon, 21 Aug 2023 13:20:42 +0100 From: Mel Gorman To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, david@redhat.com, willy@infradead.org Subject: Re: [PATCH 1/2] mm/page_alloc: remove unnecessary inner __get_pfnblock_flags_mask Message-ID: <20230821122042.4axbx7cg2nndvxaz@techsingularity.net> References: <20230811115945.3423894-1-shikemeng@huaweicloud.com> <20230811115945.3423894-2-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230811115945.3423894-2-shikemeng@huaweicloud.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 11, 2023 at 07:59:44PM +0800, Kemeng Shi wrote: > Function get_pfnblock_flags_mask just calls inline inner > __get_pfnblock_flags_mask without any extra work. Just opencode > __get_pfnblock_flags_mask in get_pfnblock_flags_mask and replace call > to __get_pfnblock_flags_mask with call to get_pfnblock_flags_mask to > remove unnecessary __get_pfnblock_flags_mask. > > Signed-off-by: Kemeng Shi Acked-by: Mel Gorman -- Mel Gorman SUSE Labs