Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <3462dfaa-96a4-61fd-b31b-fb8d8eb6104c@amd.com>
Date:   Mon, 21 Aug 2023 11:49:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH drm-misc-next 1/3] drm: drm_exec: build always builtin
Content-Language: en-US
To:     Danilo Krummrich <dakr@redhat.com>, airlied@gmail.com,
        daniel@ffwll.ch, matthew.brost@intel.com,
        thomas.hellstrom@linux.intel.com, sarah.walker@imgtec.com,
        donald.robson@imgtec.com, boris.brezillon@collabora.com,
        faith.ekstrand@collabora.com, bskeggs@redhat.com,
        Liam.Howlett@oracle.com
Cc:     dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230820215320.4187-1-dakr@redhat.com>
 <20230820215320.4187-2-dakr@redhat.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230820215320.4187-2-dakr@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TThaV0ZYYlZUd2V4ZTZzbGlzOWd2cy95Nkx6dkV4U2pXZUFoYjBpcWVjZlRZ?=
 =?utf-8?B?Yk9XR2d4SU5oTFd5WVZ4aVE4VXo2b1ExRURWeXYwRG55ZGEyaytSNTVmSG1q?=
 =?utf-8?B?ZUo3dlo4QmxESTFmTWYxRzB0UzdrL1BnTlg5ZDM1NnpvaTNITjh6TXhTRjl3?=
 =?utf-8?B?N0RDZk9INkJpNUJHTmEweTlOQjlNbzRxRUJoalFZakpZMGN3WXo2MFNXUG4z?=
 =?utf-8?B?amJ2UEJlVENSQkluSE43eEF6RWErbXVCNWpBZEVmZkhIVWt4WTBvOGVSd2FI?=
 =?utf-8?B?SGVEZW5ubzNSNXl5dTFnSWNkOGx6Nlg5dWlERmJNUkxGQ1NTWURqc1IrcW11?=
 =?utf-8?B?aUgvMVZuejRXY1BtODVpWDJtQ3FOQmZYbktOb1pzM1ZCMDBVbHk1cVRsVm5C?=
 =?utf-8?B?dEk2UW1vNzFoM1NJTmN6V3VtOUUraEZCTmY3bi9TZW16MFV2Zk5SODZCcTd5?=
 =?utf-8?B?RXlxa2pVelV0YzlvVFhOdG9zK2lOcm1EeVA1YmJ2bUxBTU01VmJOalU1ZERN?=
 =?utf-8?B?TUROWmwwUkNZbEVhT1BxZkJGVUk5a25YaEdCK01WMEtlSVpaNDQ5WEFKb3Fh?=
 =?utf-8?B?eXlmQkJ6dFRsbFhJR2tDODBBVkVrTDVBK2YyZ3ZDVVZxWFZHY0ljVThOMVVC?=
 =?utf-8?B?VGdFVEcxLzRJSm9BLzMxY1ZOL2dIVG1JbUpGeFpHK1NrN0xrR1U2VWtMR2J2?=
 =?utf-8?B?U2VHckczcG1kV3Q0Qjllb3V1eUJ4UUhjT3IrSUlUYlZPZ0xlZjJ0ZXRRdDhL?=
 =?utf-8?B?TElPYldWRU0wcnlwbXdrMDBGK3RLMDcvOHhRTDhMSWUzQWRTYjVFRUFLaVNI?=
 =?utf-8?B?RmY0TTM0NzNseWdSY0hVcEhZdVBnb3ZORTBPMFpHOE01WnQ2NWV0dEsyTmNJ?=
 =?utf-8?B?K0t4bWRINERlTHM3TTVmRlR1cnkxSFVhUDZFN2ZoQ01lNldmUlRob3dZUy9s?=
 =?utf-8?B?T3pjc01SR1RzelRMUGNhQjhUYkhQMVBlR3ljSytLNVN5WGtJZG12U0g3SzUr?=
 =?utf-8?B?ajZybzg1aEZJM1BQWER3L1pTMHE0RWEwWmh4N3VmMUhJWXRWd1RJRUR5OG9U?=
 =?utf-8?B?VHBUOFJ5OGtvWW1LNFhGOTJnYnR5TEFaeFgxQ2Z6dXdiRGdLeVlRMFBGMFdx?=
 =?utf-8?B?cDAwNDZpOHZTWnU3U0tuSGxPMHhncTFoRzI2ek9iTDM2M1ZnbE1WdEk2WmpU?=
 =?utf-8?B?c2JFdXFqVGxVektwZTArOWVXa3pmS0V1MExrQlhiMUxhM09EcCtTRThDYkZL?=
 =?utf-8?B?bEhxeGpsUkNiSi9ReHFLdnZCM0l1cm4wNTFSczZFS3JhWk9MUFJqRFl1eHlH?=
 =?utf-8?B?Zlo5S0FDNEFrdVF5ZllBTnVUWE9Bc0Zad1dpaE1NbHpKeUwrWnJsSjhTYVpa?=
 =?utf-8?B?Z0hpVWltUTNOSDNGRVdvRVlDSEE2eXBFSncySWVJMUk2bnFtNWhXNmliSWUz?=
 =?utf-8?B?RFpCd3hHeTQ3YitHbEhHT0IrdkszV2daOGJYT1lMQnZGT2FwYmNOVkd2Y1BW?=
 =?utf-8?B?Nk81Q3VMemRjQzNvUTR5K1VCcTgxMlIxbHFUNjNzem9iNUhvZVkyMFU2N1Ru?=
 =?utf-8?B?dTQwS1YzUW85bVFqZWwzSllrZERzNjc5eUV1RG5xYmxkV2tRRXdDZVpuclVS?=
 =?utf-8?B?U3EzYkxYdUNvbVM1MkRZTEh1UjlXTzI3TzYrUDBSbCtMZ2ZJN3ZXMisraDlR?=
 =?utf-8?B?Q3BwR3dtUkhZQ1ZGMnJQeXdKalJXUjB6WkFSc0FqWURwZ09pQXVLbEg4MXJz?=
 =?utf-8?B?bFloWTN5Y3pacFRGK2hiZFhha1l3UzgvOEs3aXVUU2toZnRIK09LTlJ2V1px?=
 =?utf-8?B?TlI0RTR1YWtQaHJXeFdodmp3TEltNWI4VXd4eFZlbnBVdWJuczRLVUMrbVdl?=
 =?utf-8?B?Wkd4UUtJK08xSkUvVmVmQkV6QkFmbTYyVDlOSzcvOWdhRDBzQStvb0VtanM1?=
 =?utf-8?B?SGY0cnlxNkdSYzJPaUtPL2dXNitRUEs3aCtHZUwvc3FXeHF4SEwzYTNPYWoz?=
 =?utf-8?B?U3Y2RCtyaXVLL0wzdXNQckdjZk5vVEV4NnBGZ3E2UUcrdUMyWm80eXk0YjdM?=
 =?utf-8?B?YXFhVFJVYmJLRW9iRHVhd0wzdzN4UkNvRnM5VUF6aTA0dlc5dG92dHBNaVRS?=
 =?utf-8?Q?Kex/PYHfwJagi0Q982lV7Uvk6?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9edd55bb-b5f2-45e1-af69-08dba22bfd2d
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2023 09:50:02.0193
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VqNuDfowTQH9eLQbkXDPVfldXvmtw7dgKO/mcbCycxOdXXSirL+ad7o5DQeJRlBP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6638
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 20.08.23 um 23:53 schrieb Danilo Krummrich:
> drm_exec must always be builtin for the DRM GPUVA manager to depend on
> it.

You should probably go the other way around and not always build in the 
GPUVA manager.

We have intentionally and with quite a bit of work moved the DRM_EXEC 
and DRM_BUDDY into separate modules.

Regards,
Christian.

>
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
> ---
>   drivers/gpu/drm/Kconfig         | 6 ------
>   drivers/gpu/drm/Makefile        | 3 +--
>   drivers/gpu/drm/nouveau/Kconfig | 1 -
>   3 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index ab9ef1c20349..85122d4bb1e7 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -210,12 +210,6 @@ config DRM_TTM_KUNIT_TEST
>   
>             If in doubt, say "N".
>   
> -config DRM_EXEC
> -	tristate
> -	depends on DRM
> -	help
> -	  Execution context for command submissions
> -
>   config DRM_BUDDY
>   	tristate
>   	depends on DRM
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index 215e78e79125..388e0964a875 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -23,6 +23,7 @@ drm-y := \
>   	drm_dumb_buffers.o \
>   	drm_edid.o \
>   	drm_encoder.o \
> +	drm_exec.o \
>   	drm_file.o \
>   	drm_fourcc.o \
>   	drm_framebuffer.o \
> @@ -80,8 +81,6 @@ obj-$(CONFIG_DRM_PANEL_ORIENTATION_QUIRKS) += drm_panel_orientation_quirks.o
>   # Memory-management helpers
>   #
>   #
> -obj-$(CONFIG_DRM_EXEC) += drm_exec.o
> -
>   obj-$(CONFIG_DRM_BUDDY) += drm_buddy.o
>   
>   drm_dma_helper-y := drm_gem_dma_helper.o
> diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
> index c52e8096cca4..2dddedac125b 100644
> --- a/drivers/gpu/drm/nouveau/Kconfig
> +++ b/drivers/gpu/drm/nouveau/Kconfig
> @@ -10,7 +10,6 @@ config DRM_NOUVEAU
>   	select DRM_KMS_HELPER
>   	select DRM_TTM
>   	select DRM_TTM_HELPER
> -	select DRM_EXEC
>   	select DRM_SCHED
>   	select I2C
>   	select I2C_ALGOBIT