Received: by 2002:a05:7412:1492:b0:e2:908c:2ebd with SMTP id s18csp655357rdh; Tue, 22 Aug 2023 07:06:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGT7UvxIaxshkme7zooTuTWoIrmqfL1g8ywzQ50BngedEMYnuyL6QP3+yly6w6ac/1AGb1p X-Received: by 2002:ac2:4c46:0:b0:4fe:3724:fdb1 with SMTP id o6-20020ac24c46000000b004fe3724fdb1mr7905595lfk.41.1692713194740; Tue, 22 Aug 2023 07:06:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692713194; cv=none; d=google.com; s=arc-20160816; b=0ZWikGzoFVDId3PJrZ4Ju+j7sjNz/5tE3fAGYtW8TYLZbHo0U6XQ0t2EtjnI4QG7EE Lp4QcFgnBeq5F/Ps4M/5H5U4x0AwtXDLeCOuPY+xY9qL7kRgBLviHOqvSilrO7QLfyWQ /IH0r2om0OW/1j0xgjG4l5iwmXFsfpx8hXBQ64Ssrw3OwPFzCC4DVTGJ01wYJmOOI/+k nE9XQ0UwSgUi5K55HtU33LDWOM23XrOgbUI4Zc57puUhTgvCFIPiZujYcVafcDucm1r0 JBus2wLADIJDX+yDoHhlp+tjVSCcmrWS/0hBUtXCyZAbCuMjFlBhgv5VawEar1OBEIw/ rRIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=4oi9RXnwxTpwSIx4jDXbMTYEdbbEnaXxnUTOHclOBgM=; fh=/y1k37dd1P2NbwRrpLvBa1MqxqGGQuPWK5JKi1Z7Sg8=; b=QOkQu9pRTDMFNlSpFIlZs5uZOlBCEK3+tt2mg7SNTYZQyQiZ3KnRiMqoUX87cy61ad owuy7lWLfEMDp+YiSS6v/F4lgL2LI6HvzmtLI6z3quQdJsqMAsRZxTY6t/Ycg96vO0gX LD66e+Vsw61OSxW+vc3fIrrQYEL0GrbJHPQgPCR8OarJMGns2wyDTNz51nru81QWmwDw S0oxfOjWhzLS+O//axsjcJRak8wPV6emk8qrLekNx24Si3wvnUd3DFUBFIdBII4dFzEb Ii5+YMFKGMq4urLPJKnV19vEfdrG/z8AhNJnkvXcTLXsIJAnkK1keGUwb0U07KVI3ej5 fhSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Kc9wbtP0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bm20-20020a170906c05400b00997c44fb391si1463383ejb.401.2023.08.22.07.06.08; Tue, 22 Aug 2023 07:06:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Kc9wbtP0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235882AbjHVM4b (ORCPT + 99 others); Tue, 22 Aug 2023 08:56:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235395AbjHVM4b (ORCPT ); Tue, 22 Aug 2023 08:56:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3A2ECD5; Tue, 22 Aug 2023 05:56:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 51C25653A7; Tue, 22 Aug 2023 12:56:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CF48C433C8; Tue, 22 Aug 2023 12:56:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692708988; bh=2WNX9QQVAoAuPFyHg3TYLIP+sACknmV5BgHbBDJLXhg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Kc9wbtP019ThJqTZl07TKJdIhRJV8MLPsBxb6Bpoaq511RbNdjQva/I5VkTXMePXq xvFhDnBgHVwsbleZbHEy0Zy817mp44jSaT9epmtiPtNAx15KgjRkhjvm4kxHxLqpoa tjuYkcSO08QKQcqSQm7TtkTaWtz/en9nCFU7MSChqqBrzdaMCABurvhXLLHDrBliPe WSqZim9GcJwi/FxUl7jhuNm4cSGN37j2ScUwtYMtDD4avD/4LAqJf+a1GDBrK9fG7V u/T8IHmkCUSd9709CN1Cn0XsigAmn4c2n76TC6tUWPGvPeaUe9QENW78p6z40y26Ue wTaS/FD140PcQ== From: Kalle Valo To: Johan Hovold Cc: Jeff Johnson , Bjorn Andersson , Manivannan Sadhasivam , Konrad Dybcio , Manikanta Pubbisetty , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "Revert "wifi: ath11k: Enable threaded NAPI"" References: <20230809073432.4193-1-johan+linaro@kernel.org> Date: Tue, 22 Aug 2023 15:56:24 +0300 In-Reply-To: (Johan Hovold's message of "Mon, 21 Aug 2023 15:41:37 +0200") Message-ID: <87o7izi6br.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johan Hovold writes: > Hi Kalle, > > On Wed, Aug 09, 2023 at 09:34:32AM +0200, Johan Hovold wrote: > >> Disabling threaded NAPI caused a severe regression in 6.5-rc5 by making >> the X13s completely unusable (e.g. no keyboard input, I've seen an RCU >> splat once). >> >> I'm supposed to be on holiday this week, but thanks to the rain I gave >> rc5 a try and ran into this. >> >> I've added Bjorn, Mani and Konrad on CC who may be able to help with >> debugging this further if needed while I'm out-of-office. > > Back from my holiday now, and this regression is still there with > 6.5-rc7. I was also away but back now. > Any chance we can get the offending commit reverted before 6.5 is > released? The problem here is that would break QCN9074 again so there is no good solution. I suspect we have a fundamental issue in ath11k which we just haven't discovered yet. I would prefer to get to the bottom of this before reverting anything. > I'll take a closer look at this meanwhile. Thanks, much appreciated. Did you try enabling all kernel debug features, maybe they would give some hints? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches