Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230822164859.26b0b8f6@canb.auug.org.au> <CAMj1kXGKtpGNYx6hqygya+k_gQaMTiwEZnRGk9rZ=hcbcagKXA@mail.gmail.com>
 <20230822180805.483c10ee@canb.auug.org.au>
In-Reply-To: <20230822180805.483c10ee@canb.auug.org.au>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Tue, 22 Aug 2023 10:41:20 +0200
Message-ID: <CAMj1kXF4eQBYiPBv2asbu+yqcCuYSmw-8_x41u=g4s1NJjb1Xg@mail.gmail.com>
Subject: Re: linux-next: build failure after merge of the efi tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 22 Aug 2023 at 10:08, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Ard,
>
> On Tue, 22 Aug 2023 09:32:31 +0200 Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > Hello Stephen,
> >
> > On Tue, 22 Aug 2023 at 08:49, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the efi tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > In file included from drivers/platform/x86/uv_sysfs.c:14:
> > > arch/x86/include/asm/uv/bios.h:118:22: error: expected ')' before '*' token
> > >   118 |         u64 (__efiapi *function)(enum uv_bios_cmd, ...);
> > >       |                      ^~
> > >       |                      )
> > >
> > > Caused by commit
> > >
> > >   73632c8c865f ("efi/runtime-wrappers: Remove duplicated macro for service returning void")
> > >
> >
> > Thanks for the report.
> >
> > I cannot reproduce this with Debian's GCC 12.2.0 when building the
> > efi/next tree either in isolation, or merged into yesterday's next.
> >
> > Could you please share the compiler version and the .config you used? Thanks.
>
> $ x86_64-linux-gnu-gcc --version
> x86_64-linux-gnu-gcc (Debian 12.3.0-4) 12.3.0
> (this is Debian's cross compiler that is ppcle64 hosted)
>
> and (see above) it is a x86_64 allmodconfig build.
>
> Maybe there is some interaction with something else in today's
> linux-next (just released).

Thanks. I fixed it in the efi/next tree so things should build as
expected the next time around.