Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230813025220.1752489-1-rui.zhang@intel.com>
In-Reply-To: <20230813025220.1752489-1-rui.zhang@intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 22 Aug 2023 22:08:35 +0200
Message-ID: <CAJZ5v0gLnqxTPux9x=aGhLQoNAwkANPy4UoT0gYEchayE20=DQ@mail.gmail.com>
Subject: Re: [PATCH V2] thermal: intel: intel_soc_dts_iosf: Remove redundant check
To:     Zhang Rui <rui.zhang@intel.com>
Cc:     rafael.j.wysocki@intel.com, daniel.lezcano@linaro.or,
        srinivas.pandruvada@intel.com, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Sun, Aug 13, 2023 at 4:52 AM Zhang Rui <rui.zhang@intel.com> wrote:
>
> Remove the redundant check in remove_dts_thermal_zone() because all of
> its existing callers pass a valid pointer as the argument.
>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
>  drivers/thermal/intel/intel_soc_dts_iosf.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c b/drivers/thermal/intel/intel_soc_dts_iosf.c
> index db97499f4f0a..22fc2970c67d 100644
> --- a/drivers/thermal/intel/intel_soc_dts_iosf.c
> +++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
> @@ -245,11 +245,9 @@ static int soc_dts_enable(int id)
>
>  static void remove_dts_thermal_zone(struct intel_soc_dts_sensor_entry *dts)
>  {
> -       if (dts) {
> -               iosf_mbi_write(BT_MBI_UNIT_PMC, MBI_REG_WRITE,
> -                              SOC_DTS_OFFSET_ENABLE, dts->store_status);
> -               thermal_zone_device_unregister(dts->tzone);
> -       }
> +       iosf_mbi_write(BT_MBI_UNIT_PMC, MBI_REG_WRITE,
> +                      SOC_DTS_OFFSET_ENABLE, dts->store_status);
> +       thermal_zone_device_unregister(dts->tzone);
>  }
>
>  static int add_dts_thermal_zone(int id, struct intel_soc_dts_sensor_entry *dts,
> --

Applied as 6.6 material, thanks!