Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756720AbXKDTBc (ORCPT ); Sun, 4 Nov 2007 14:01:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754231AbXKDTBO (ORCPT ); Sun, 4 Nov 2007 14:01:14 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:50339 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754052AbXKDTBN (ORCPT ); Sun, 4 Nov 2007 14:01:13 -0500 Date: Sun, 4 Nov 2007 11:06:56 -0800 From: Greg KH To: James Bottomley Cc: Stefan Richter , Kay Sievers , linux-scsi , linux-kernel Subject: Re: [PATCH] sysfs: add filter function to groups Message-ID: <20071104190656.GA23669@kroah.com> References: <1193671019.3383.13.camel@localhost.localdomain> <1193676852.2655.21.camel@lov.site> <1193677071.3383.56.camel@localhost.localdomain> <47261F50.3050901@s5r6.in-berlin.de> <1193768743.3321.91.camel@localhost.localdomain> <20071031035506.GH14910@kroah.com> <1193841484.3411.8.camel@localhost.localdomain> <20071031172943.GA29492@kroah.com> <1194185522.3434.7.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1194185522.3434.7.camel@localhost.localdomain> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 35 On Sun, Nov 04, 2007 at 08:12:02AM -0600, James Bottomley wrote: > On Wed, 2007-10-31 at 10:29 -0700, Greg KH wrote: > > On Wed, Oct 31, 2007 at 09:38:04AM -0500, James Bottomley wrote: > > > On Tue, 2007-10-30 at 20:55 -0700, Greg KH wrote: > > > > OSame problem here, if grp->is_visible is not set, sysfs_add_file() would > > > > never be called, right? > > > > > > > > Other than the logic problem (I think), I have no issue with this idea > > > > at all. Care to redo this so it works? > > > > > > It's a fair cop govenor ... new patch attached. > > > > Much better, thanks :) > > > > I have no problem with this, if you want to take this in your tree, > > please do and feel free to add: > > Signed-off-by: Greg Kroah-Hartman > > > > to it, or I can take it in mine. > > Actually, I think I have a use for it and the follow on patch (coming > soon) to do attribute bitmaps in the SCSI tree, so I'd like to add your > ack and take it through this tree. That's fine. Can you CC: me on the patch that uses this code so I can see how well it works out? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/