Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Aug 2023 05:41:46 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Dexuan Cui <decui@microsoft.com>
Cc:     Nathan Chancellor <nathan@kernel.org>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
        Tianyu Lan <Tianyu.Lan@microsoft.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
Subject: Re: [PATCH] x86/hyperv: Add missing 'inline' to hv_snp_boot_ap() stub
Message-ID: <ZOWcGnu7pqA4m2Ar@liuwe-devbox-debian-v2>
References: <20230822-hv_snp_boot_ap-missing-inline-v1-1-e712dcb2da0f@kernel.org>
 <SA1PR21MB1335C1D74D05A582D90EA1A9BF1CA@SA1PR21MB1335.namprd21.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <SA1PR21MB1335C1D74D05A582D90EA1A9BF1CA@SA1PR21MB1335.namprd21.prod.outlook.com>
Precedence: bulk

On Wed, Aug 23, 2023 at 01:00:55AM +0000, Dexuan Cui wrote:
> > From: Nathan Chancellor <nathan@kernel.org>
> > Sent: Tuesday, August 22, 2023 11:26 AM
> > [...]
> > When building without CONFIG_AMD_MEM_ENCRYPT, there are several
> > repeated instances of -Wunused-function due to missing 'inline' on
> > the stub of hy_snp_boot_ap():
> > 
> >   In file included from drivers/hv/hv_common.c:29:
> >   ./arch/x86/include/asm/mshyperv.h:272:12: error: 'hv_snp_boot_ap'
> > defined but not used [-Werror=unused-function]
> >     272 | static int hv_snp_boot_ap(int cpu, unsigned long start_ip) { return
> > 0; }
> >         |            ^~~~~~~~~~~~~~
> >   cc1: all warnings being treated as errors
> > 
> > Add 'inline' to fix the warnings.
> > 
> > Fixes: 44676bb9d566 ("x86/hyperv: Add smp support for SEV-SNP guest")
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> 
> Reviewed-by: Dexuan Cui <decui@microsoft.com>

Applied. Thanks.