Received: by 2002:a05:7412:1492:b0:e2:908c:2ebd with SMTP id s18csp657303rdh; Wed, 23 Aug 2023 10:48:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUbgjIJEnCUCUrEJi5XaciWbbc1/aAZw0tCk/HWkuSO/vhOXAlPQENTh41Y4tlCtuXi9I8 X-Received: by 2002:a05:6808:314:b0:3a7:60f7:c9ad with SMTP id i20-20020a056808031400b003a760f7c9admr15396594oie.13.1692812920912; Wed, 23 Aug 2023 10:48:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692812920; cv=none; d=google.com; s=arc-20160816; b=GfueDYa+WWONUSOLQw27DoHYx/kUbOILXywFLqYIvw6/qn/gj390jMOI+Bm1a0rnaa niz2qvYw9WoSS/oPxeQChYArztWRaLNgD8zuiiiuKCNG9JLeOsJG4YJ229SOAnOwzBHg //2+PReFtYU8gEylMjtW6uc7aLy5x/VF8Zd8vjvKVvGuI/qO3GCZ3GGSLclLxqJGaBHY VjCB1pwP95SfWvf8pfwdXyCYXrAhkZoPooVX89p/g7fUAaEVUi61gaCO6B9ZKbLT73d0 zik9VWj3ul4kbc4GtO5nixF2ShOS870K/sk+Y5jfKWQjgjZ/K0iC6UmZR/s6Ntzv4TIX shbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=imhL2C+y7HICzkD6PnklPZXn+h7zvUJHu98QuJz6fJQ=; fh=ueKZh+WG55YfcGhmNCDk9TALM9dTa6rDmJ6HzTOhg8M=; b=Hoe+15tcHLWXQ+MBwTwLswpYbtmNikVy8NwLe9Ev6w5KSTwN722WtLCX7LQzVOVk9C aZ5E8QykYQ3OQhYxNAT2XZuNhclwRDKfE0MBLRfMImUNuduaBdAjZOf35I6QS26Y2sI5 2mwP/i1phtZuF1gpYVbfeQvOlDxUA6Ys/D9ISxc2q8AI/3RCM7QCAVPiYkDxXbxvUalT UMDHqwugVyOPcArvcnRgAkl1s+xTR5ajZgp2FULpgYuQyxb2F4ayLxqXHgF96O73WXZ3 OzKwqvoE4xCty3MYhwvLUGPEySvj49ytwPuaVAoLPApfgwMxUovJUV+Z3tVWp6i5JOZd 1ryg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x10-20020a65538a000000b00565e6bce28bsi11262012pgq.796.2023.08.23.10.48.24; Wed, 23 Aug 2023 10:48:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234754AbjHWMEg (ORCPT + 99 others); Wed, 23 Aug 2023 08:04:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234706AbjHWMEE (ORCPT ); Wed, 23 Aug 2023 08:04:04 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 203F4E77 for ; Wed, 23 Aug 2023 05:03:58 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4RW4cs31yXz4x2n; Wed, 23 Aug 2023 22:03:57 +1000 (AEST) From: Michael Ellerman To: Nicholas Piggin , Christophe Leroy Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org In-Reply-To: References: Subject: Re: [PATCH v2] powerpc/ptrace: Split gpr32_set_common Message-Id: <169279175565.797584.14665256369695357987.b4-ty@ellerman.id.au> Date: Wed, 23 Aug 2023 21:55:55 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Jun 2023 12:01:23 +0200, Christophe Leroy wrote: > objtool report the following warning: > > arch/powerpc/kernel/ptrace/ptrace-view.o: warning: objtool: > gpr32_set_common+0x23c (.text+0x860): redundant UACCESS disable > > gpr32_set_common() conditionnaly opens and closes UACCESS based on > whether kbuf point is NULL or not. This is wackelig. > > [...] Applied to powerpc/next. [1/1] powerpc/ptrace: Split gpr32_set_common https://git.kernel.org/powerpc/c/9a32584bc108c8fe4d02fa33b16caf686e4a788a cheers