Received: by 2002:a05:7412:1492:b0:e2:908c:2ebd with SMTP id s18csp682938rdh; Wed, 23 Aug 2023 11:31:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGyTz8wJlbaVY2/2qfZApPr2YahFnhpQEe9PrNKnxpNCrOFOFzIRiU4JeXCiuyZwMyHCb2 X-Received: by 2002:a17:902:d2c7:b0:1bb:a125:f831 with SMTP id n7-20020a170902d2c700b001bba125f831mr14788359plc.58.1692815514010; Wed, 23 Aug 2023 11:31:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692815513; cv=none; d=google.com; s=arc-20160816; b=brGysvxRMXkfa9PppeWuO6V/GXQ78eNkItfI3QNv6phWOg6S8hCkJclSlgRGdz4TmG hLC0Ctxb3Fu2F6tUz/FCKm6DwYAloPQNfvYmEA9c4u22DTf63hgTvQEswWlXIJAk+IVm YHAYWqdwBvk4p65CPNhvzYTrOap0naWw01NIYLvcBaC9KC1SAz5EoYiLWj00FiP4r11y JCMtRAcO0Bd9a0X1Hu6wxbg91Y2KO9qnoRCbzOpdNjxq0HMLXCow91ZznwJjUWrd0AXV 588YawvZgmv4hqHOFLrhrF6hHASMdkzvWzy0n0vVgrGq0513Coo+KIt5JQ+z99t6lDn6 2uZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pQPrHId/lCHDPLFw57GJfdnbAiLt5erdzCNTXGSDhdo=; fh=1UHN2vYFDg1VELwt62RkkNSS7rhAuJQ/UuEEWkjgt1M=; b=wxx0tjK+Y4VYC8mCdEhn57oXsRNyIDUA3wXcwO3lSVVLPK5Jnqfv11K7tmyCPClj5M mtgk9Xk4OdHYL+/V6+EKBXBSGRlgSZFyK2KXWfHbq+pSGbHjWhXkUyp7711qgLs4ynHm 4GDwrJjAC1p5vjFe2gPgFt8huy4ejESA5LnDQ1U7wW8C273yXysGTbQryhqVL5JT5ZyR v1et0fhWD5LIDy0D64TU+i8Nr1oseHoHKslGet7Xqnz5uPBHpZdqF6+noxE6RA3wFzr1 nU74ckXGvgzkD2kk6wiiOPvdQ3PSkMI+xlD+7SmDBiQD+D9avSb+uMM12x82b39ai0LX r9QQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=Ie2ANdwP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j7-20020a170902da8700b001b8b437b01esi12507547plx.350.2023.08.23.11.31.40; Wed, 23 Aug 2023 11:31:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=Ie2ANdwP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229723AbjHVSCt (ORCPT + 99 others); Tue, 22 Aug 2023 14:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbjHVSCm (ORCPT ); Tue, 22 Aug 2023 14:02:42 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 208C7CC; Tue, 22 Aug 2023 11:02:41 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1bf078d5fb7so31628845ad.0; Tue, 22 Aug 2023 11:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692727360; x=1693332160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pQPrHId/lCHDPLFw57GJfdnbAiLt5erdzCNTXGSDhdo=; b=Ie2ANdwPuvvaJZxkLtrV0mygSDZzPCCbtaixTP8JhVB/Dc8l9V7ZwtmGdhFz5nHUp8 0pwhfQZmLpaJW8iDA2VwHvcAgkKpV0TMqB9fKSlHP7RDEocY2yvNGjhM95DxrPb8fidf FlIJaGh+hNfhxNGHXNRMtQy2Bwu71FYUO/2lsS+d0iD75UwGCdHdk+430CWP03moOP/g vh1w62NFiGunZUR5wq3X8AXFQHYj7/ZNM0nvpnAGGzLB7biAnJZAKd/hS/75nPJidBRd wyB7HRXthbT3p8bRWgKtAX5Wh9DXBfund8EKANorutH3NVpoOehVuli/wxpVea/0kRs9 FAUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692727360; x=1693332160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pQPrHId/lCHDPLFw57GJfdnbAiLt5erdzCNTXGSDhdo=; b=NV7eOdpwyf22aGloh5Tr5HzLMuSfyhavubVTydg6XeL7aHzsiplqRTRJFZ7DTlu433 9li4AMWSfqo+oBPVRlzm/JLB+OvMkx5eKRuz0Xy+M2sJQ4AvVkWQNu+uNBX0z/p1af/d k3NpP2hbLRcczPZ4JpMYJMOE27jbPExYYbe1IZQXHEOqfgerfK/NP+EBOxuOrNTHWBBx ijSVwbO33Sa/XnSUDJEuz1BAAECgSS2b1xc2RbkvF76ij1NIcG4MKi2Rk23rdQMGi3vN I0xOOoi10XCiaeff3HlCLaKgzdxqgwqSwgdduUltMoab7kZAp+R977DLqLlQfd2/hsrK vwsg== X-Gm-Message-State: AOJu0YzscdrVEfr/oNOXZ4rmcPIag44pQsjdHcH351knpanIQsKhZ8KQ Jb4g2RTziYHLGK6jTinb03I= X-Received: by 2002:a17:902:c086:b0:1bc:5924:2da2 with SMTP id j6-20020a170902c08600b001bc59242da2mr8036097pld.56.1692727360397; Tue, 22 Aug 2023 11:02:40 -0700 (PDT) Received: from localhost ([2a00:79e1:abd:4a00:6c80:7c10:75a0:44f4]) by smtp.gmail.com with ESMTPSA id f5-20020a170902684500b001bf6ea340b3sm5744775pln.116.2023.08.22.11.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Aug 2023 11:02:39 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , linux-pm@vger.kernel.org (open list:HIBERNATION (aka Software Suspend, aka swsusp)), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v5 05/11] PM / QoS: Teach lockdep about dev_pm_qos_mtx locking order Date: Tue, 22 Aug 2023 11:01:52 -0700 Message-ID: <20230822180208.95556-6-robdclark@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230822180208.95556-1-robdclark@gmail.com> References: <20230822180208.95556-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rob Clark Annotate dev_pm_qos_mtx to teach lockdep to scream about allocations that could trigger reclaim under dev_pm_qos_mtx. Signed-off-by: Rob Clark --- drivers/base/power/qos.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/base/power/qos.c b/drivers/base/power/qos.c index 09834f3354d7..2018c805a6f1 100644 --- a/drivers/base/power/qos.c +++ b/drivers/base/power/qos.c @@ -1017,3 +1017,14 @@ void dev_pm_qos_hide_latency_tolerance(struct device *dev) pm_runtime_put(dev); } EXPORT_SYMBOL_GPL(dev_pm_qos_hide_latency_tolerance); + +static int __init dev_pm_qos_init(void) +{ + /* Teach lockdep about lock ordering wrt. shrinker: */ + fs_reclaim_acquire(GFP_KERNEL); + might_lock(&dev_pm_qos_mtx); + fs_reclaim_release(GFP_KERNEL); + + return 0; +} +early_initcall(dev_pm_qos_init); -- 2.41.0