Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7c94dd6a-4fab-10dc-b0bb-2d9caa16a148@hisilicon.com>
Date:   Thu, 24 Aug 2023 15:58:15 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.0
Subject: Re: [PATCH for-next 0/3] RDMA/hns: Add more debugging information for
 rdma-tool
To:     Leon Romanovsky <leon@kernel.org>
CC:     <jgg@nvidia.com>, <linux-rdma@vger.kernel.org>,
        <linuxarm@huawei.com>, <linux-kernel@vger.kernel.org>
References: <20230816091812.2899366-1-huangjunxian6@hisilicon.com>
 <20230819113212.GN22185@unreal>
Content-Language: en-US
From:   Junxian Huang <huangjunxian6@hisilicon.com>
In-Reply-To: <20230819113212.GN22185@unreal>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2023/8/19 19:32, Leon Romanovsky wrote:
> On Wed, Aug 16, 2023 at 05:18:09PM +0800, Junxian Huang wrote:
>> 1. #1: The first patch supports dumping QP/CQ/MR context entirely in raw
>>        data with rdma-tool.
>>
>> 2. #2: The second patch supports query of HW stats with rdma-tool.
>>
>> 3. #3: The last patch supports query of SW stats with rdma-tool.
>>
>> Chengchang Tang (3):
>>   RDMA/hns: Dump whole QP/CQ/MR resource in raw
>>   RDMA/hns: Support hns HW stats
> 
> These two patches generate static analyzer warnings.
> ➜  kernel git:(wip/leon-for-next) mkt ci --rev 0a68261bbbe5
> 0a68261bbbe5 (HEAD -> build) RDMA/hns: Dump whole QP/CQ/MR resource in raw
> WARNING: 'informations' may be misspelled - perhaps 'information'?
> #7:
> rdma-tool, but these informations are not enough. It is very
>                      ^^^^^^^^^^^^
> ➜  kernel git:(wip/leon-for-next) mkt ci
> 5a87279591a1 (HEAD -> build) RDMA/hns: Support hns HW stats
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c:1651:35: warning: restricted __le16 degrades to integer
> 

OK，I'll fix them in V2.

>>   RDMA/hns: Support hns SW stats
> 
> This is not support SW stats, but actually implementation of SW
> statistics which you exposed through rdmatool. That tool is

Yes,

> not right place for such information and debugfs will be better
> fit.
> 
> Thanks
> 

but from what I have seen, efa and bnxt_re drivers also use rdmatool
to expose SW statisics.

And could you please explain why rdmatool is not suitable for this?

Junxian

>>
>>  drivers/infiniband/hw/hns/hns_roce_ah.c       |   6 +-
>>  drivers/infiniband/hw/hns/hns_roce_cmd.c      |  19 ++-
>>  drivers/infiniband/hw/hns/hns_roce_cq.c       |  15 +-
>>  drivers/infiniband/hw/hns/hns_roce_device.h   |  50 ++++++
>>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c    |  59 +++++++
>>  drivers/infiniband/hw/hns/hns_roce_hw_v2.h    |   1 +
>>  drivers/infiniband/hw/hns/hns_roce_main.c     | 152 +++++++++++++++++-
>>  drivers/infiniband/hw/hns/hns_roce_mr.c       |  26 ++-
>>  drivers/infiniband/hw/hns/hns_roce_pd.c       |  10 +-
>>  drivers/infiniband/hw/hns/hns_roce_qp.c       |   8 +-
>>  drivers/infiniband/hw/hns/hns_roce_restrack.c |  75 +--------
>>  drivers/infiniband/hw/hns/hns_roce_srq.c      |   6 +-
>>  12 files changed, 325 insertions(+), 102 deletions(-)
>>
>> --
>> 2.30.0
>>