Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230822040248.329442-1-chenhuacai@loongson.cn> <87lee0dbmi.ffs@tglx>
In-Reply-To: <87lee0dbmi.ffs@tglx>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Thu, 24 Aug 2023 20:52:30 +0800
Message-ID: <CAAhV-H6MWOVkgJYa6CedoiQ9YG+Jw_vTLZN-NY5Jrn5Ps5HUAg@mail.gmail.com>
Subject: Re: [PATCH V3] rcu: Update jiffies locally in rcu_cpu_stall_reset()
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Frederic Weisbecker <frederic@kernel.org>,
        Neeraj Upadhyay <quic_neeraju@quicinc.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Josh Triplett <josh@joshtriplett.org>,
        Boqun Feng <boqun.feng@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Zqiang <qiang.zhang1211@gmail.com>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, Binbin Zhou <zhoubinbin@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Thomas,

On Thu, Aug 24, 2023 at 5:37=E2=80=AFPM Thomas Gleixner <tglx@linutronix.de=
> wrote:
>
> On Tue, Aug 22 2023 at 12:02, Huacai Chen wrote:
> > + * This function may be called in NMI context, so we cannot use ktime_=
get_ns()
> > + * and ktime_get_coarse_ns(). Instead, we use their inaccurate but saf=
e friends
> > + * ktime_get_mono_fast_ns() and ktime_get_seconds() which will cause r=
cu_state.
> > + * jiffies_stall to be a little large than expected (harmless and safe=
r).
>
> What's inaccurate about ktime_get_mono_fast_ns()? Bogus comments are
> even worse than no comments.
ktime_get_mono_fast_ns() is not as accurate as ktime_get_ns(), I get
this conclusion from:

 * So if the update lowers the slope, readers who are forced to the
 * not yet updated second array are still using the old steeper slope.

>
> >   */
> >  void rcu_cpu_stall_reset(void)
> >  {
> > +     u64 curr, last, delta;
> > +
> > +     curr =3D ktime_get_mono_fast_ns();
> > +     last =3D ktime_get_seconds() * NSEC_PER_SEC;
>
> So this will trigger a warning when someone debugs suspend with KGDB.
Yes, ktime_get_seconds() may cause a warning, I haven't noticed this before=
.

>
> It seems the approach taken here seems to be to throw stuff at the wall
> and see what sticks.
I don't understand what's meaning, but I believe your advice in
another thread is the best solution, so let me try.

Huacai

>
> Thanks,
>
>         tglx