Received: by 2002:a05:7412:1703:b0:e2:908c:2ebd with SMTP id dm3csp418235rdb; Thu, 24 Aug 2023 09:42:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHWVIqOdQKkMLqGRAYhbtnpEIBEEbIvDbC8tiJkWImp+BhSi2agaWHDBbtw9JwTbMchMjV X-Received: by 2002:a17:90a:d80e:b0:263:9816:fe0f with SMTP id a14-20020a17090ad80e00b002639816fe0fmr15090207pjv.15.1692895323276; Thu, 24 Aug 2023 09:42:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692895323; cv=none; d=google.com; s=arc-20160816; b=NayoUQ3ToEK0qbEt0YG7i5NKzwYBTv8ykXgVCPi6paw43oBGHMYsD1x+p1SvAPrIv1 /0N92tRnhtcBJlZPngbuB+DnuXH5HPqSElKAYiXthXF/Y8Mte3KaUMN9uzwMJgLpWVaq 8KD3O3k4TOgbyXowKVPcWEsIc6AL1dxkoKqmoPK+GQUXD7/g0QDaQ6v89JiruEGvVU0j ijuHblK0zNtmz6QczYQfKxZFpwb6MXKCmRs0+/ck6yqMDm8lKxm/AAHUZmZoxY2CVf26 OuCPhbtRh494//gXokVrlXIBUtmJRg6P/f9ygJZsNxcXjeQw9thT5tBduckxDomHsq5i pvsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TwM25ds4A9mtQNXztcP5W7WT45skbSiDB3ybAVthh+0=; fh=DBBDkUQQRTMf1KV4VG+TlSVdnmy4m5XA1zDOiUyVIrw=; b=U0iZ0SuDD4SwEBmUkWQAlnHsVOFuCK9naDBmP6rJHMZr8KaLwDcDsOwsMrXJ9uyyqR FYm7llnFvjXilYuwg8MJUXTwuDZQFdgYpMmvXCB9uVCrLjO/GH84YLF2eHCboRfoNUwq iDo2bEOmec+wAboda9zzIk2+VhS+e5lUX9TvKEbDt+et2OUV3ucPCTOSDUVpQG7Onm1u ZMqajA0ulh1j5sO6jybvlJBm9zKNlzTMkJzhqFVBolD+pYc9gTKykDL2swjxaqK7dzCg B+qr7nuta14wiSewthb1j8RYWNw7LkRvu1GJPYhHi02yKPpNT2HUS143dIx3OgXlXcNi kwDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="CqOlaS/Q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id na13-20020a17090b4c0d00b00263deaac48esi2693463pjb.8.2023.08.24.09.41.51; Thu, 24 Aug 2023 09:42:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="CqOlaS/Q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234548AbjHXMYf (ORCPT + 99 others); Thu, 24 Aug 2023 08:24:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233306AbjHXMYO (ORCPT ); Thu, 24 Aug 2023 08:24:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C886E10EF; Thu, 24 Aug 2023 05:24:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6654063388; Thu, 24 Aug 2023 12:24:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC2CBC433C7; Thu, 24 Aug 2023 12:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692879851; bh=rXHeHAFXjN/zA3rYC/1HhA1l11PWkd2Qvj22VCRsCGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CqOlaS/QfUs5XXJTiSG68eVAETcwld0Oyyw2XmGw3vbPcDbOEpspeApsyEBSY0lzY BJl4NEsEvECi0Fn66tjoluhCVVSbj/3Fe3eaBPUimBzycU6Ew02hPKbed/8je8CkRf 1+WsWnIyZzbwSlIn/6j5RP45+CkV50Bn18C+mlY07Wd9kkPeHC9Xv+VQYWAGMT8iqG LXQzMPYXHDBPiYetArnubErS0XhVoCULd5vNPc0T7OZ+5eZRVXxQpCJkyh5R3oVYEa qX2bk7/9/M9K5EutOOlmwBQ30zkp0qc/t1PRSgiuL+KJDx47ih8QPQIzlYGQ4Wflwi HyIl1AsJiWaIg== Date: Thu, 24 Aug 2023 13:24:01 +0100 From: Lee Jones To: Hamza Mahfooz Cc: Jani Nikula , Karol Herbst , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Mikko Perttunen , =?iso-8859-1?Q?Ma=EDra?= Canal , Thierry Reding , Laurent Pinchart , Sumit Semwal , Shashank Sharma , Michal Simek , amd-gfx@lists.freedesktop.org, Jonathan Hunter , Luben Tuikov , Danilo Krummrich , Ben Skeggs , Stanley Yang , linux-media@vger.kernel.org, Thomas Zimmermann , Sascha Hauer , Maxime Ripard , linaro-mm-sig@lists.linaro.org, linux-tegra@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, Hyun Kwon , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Hawking Zhang , Jerome Glisse , Pengutronix Kernel Team , Alex Deucher , Gourav Samaiya , Shawn Guo , Christian =?iso-8859-1?Q?K=F6nig?= , Mario Limonciello Subject: Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Message-ID: <20230824122401.GY1380343@google.com> References: <20230824073710.2677348-1-lee@kernel.org> <87wmxk4xt3.fsf@intel.com> <20230824120735.GS1380343@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Aug 2023, Hamza Mahfooz wrote: > > On 8/24/23 08:07, Lee Jones wrote: > > On Thu, 24 Aug 2023, Jani Nikula wrote: > > > > > On Thu, 24 Aug 2023, Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > The next question is, how do we keep it W=1 clean going forward? > > > > My plan was to fix them all, then move each warning to W=0. > > > > Arnd recently submitted a set doing just that for a bunch of them. > > > > https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/ > > > > I like to think a bunch of this is built on top of my previous efforts. > > > > GPU is a particularly tricky though - the warnings seem to come in faster > > than I can squash them. Maybe the maintainers can find a way to test > > new patches on merge? > > I guess on that note, do you know if there is a way to run > `scripts/kernel-doc` on patches instead of whole files? That would make > much easier to block new kernel-doc issues from appearing. Not off hand. When I run builds on patches I author, I run them twice concurrently. Once on the commit I'm basing on and once on the HEAD of my patchset. I then diff the two. So as long as the number of errors and warnings stay the same or reduce, we're golden. Perhaps the same method could be used with `kernel-doc`? -- Lee Jones [李琼斯]