Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <689cfe0d-a323-b48c-8543-4ddd74258fc0@kernel.org>
Date:   Fri, 25 Aug 2023 17:10:23 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] ata: pata_ep93xx: fix error return code in probe
Content-Language: en-US
To:     Nikita Shubin <nikita.shubin@maquefel.me>,
        Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230823-ep93xx_pata_fixes-v1-0-d7e7229be148@maquefel.me>
 <20230823-ep93xx_pata_fixes-v1-1-d7e7229be148@maquefel.me>
 <00462bc7-43ee-784a-3296-8051d69575df@kernel.org>
 <913a0bc0dfcd3ecd28f65fb52db789033097d831.camel@maquefel.me>
From:   Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <913a0bc0dfcd3ecd28f65fb52db789033097d831.camel@maquefel.me>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/25/23 17:05, Nikita Shubin wrote:
> Hi Damien!
> 
> On Thu, 2023-08-24 at 08:07 +0900, Damien Le Moal wrote:
>> On 8/23/23 18:47, Nikita Shubin via B4 Relay wrote:
>>> From: Nikita Shubin <nikita.shubin@maquefel.me>
>>>
>>> Return -ENOMEM from ep93xx_pata_probe() if devm_kzalloc() or
>>> ata_host_alloc() fails.
>>>
>>> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
>>
>> Doesn't this need a Fixes tag and Cc: stable ?
>>
>> This is not really a bug fix, but might as well be complete with the
>> fix :)
> 
> Well... This would be fix for:
> 
> ```
> commit 2fff27512600f9ad91335577e485a8552edb0abf
> Author: Rafal Prylowski <prylowski@metasoft.pl>
> Date:   Thu Apr 12 14:13:16 2012 +0200
> ```
> 
> v3.4-rc6-6-g2fff27512600
> 
> Are you sure we wanna tag so solid and time proven commit as Fixes: :)
> ?

Yeah, this is fine without the fixes tag. As I said, not exactly a bug fix but
rather an improvement :)

-- 
Damien Le Moal
Western Digital Research