Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ffd6004f-f30c-8bc3-096b-e3bce93ee864@huawei.com>
Date:   Sat, 26 Aug 2023 12:37:27 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH 1/2] ACPI: NFIT: Fix incorrect calculation of idt size
Content-Language: en-US
To:     Dave Jiang <dave.jiang@intel.com>, <dan.j.williams@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <rafael@kernel.org>
CC:     <liwei391@huawei.com>, <lenb@kernel.org>, <robert.moore@intel.com>,
        <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230817091124.915407-1-liaoyu15@huawei.com>
 <a29d4ef5-fba2-b1f4-9c48-5c125dbe0e27@huawei.com>
 <789c18d7-8227-4dfc-438a-2959448f9547@intel.com>
From:   Yu Liao <liaoyu15@huawei.com>
In-Reply-To: <789c18d7-8227-4dfc-438a-2959448f9547@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2023/8/25 23:09, Dave Jiang wrote:
> 
> 
> On 8/24/23 20:59, Yu Liao wrote:
>> Hi,
>>
>> A kindly ping, any comment on this?
> 
> You can add my review tag to both of your patches in the series. Please cc
> nvdimm@lists.linux.dev next time as well for nfit. Thanks!

Thank you for the review. I'll make the suggested changes and send you
the V2.

Best regards,
Yu
> 
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> 
>>
>> Best regards,
>> Yu
>>
>>
>> On 2023/8/17 17:11, Yu Liao wrote:
>>> acpi_nfit_interleave's field 'line_offset' is switched to flexible array [1],
>>> but sizeof_idt() still calculates the size in the form of 1-element array.
>>>
>>> Therefore, fix incorrect calculation in sizeof_idt().
>>>
>>> [1] https://lore.kernel.org/lkml/2652195.BddDVKsqQX@kreacher/
>>>
>>> Fixes: 2a5ab99847bd ("ACPICA: struct acpi_nfit_interleave: Replace
>>> 1-element array with flexible array")
>>> Cc: stable@vger.kernel.org # v6.4+
>>> Signed-off-by: Yu Liao <liaoyu15@huawei.com>
>>> ---
>>>   drivers/acpi/nfit/core.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
>>> index 07204d482968..305f590c54a8 100644
>>> --- a/drivers/acpi/nfit/core.c
>>> +++ b/drivers/acpi/nfit/core.c
>>> @@ -855,7 +855,7 @@ static size_t sizeof_idt(struct acpi_nfit_interleave *idt)
>>>   {
>>>       if (idt->header.length < sizeof(*idt))
>>>           return 0;
>>> -    return sizeof(*idt) + sizeof(u32) * (idt->line_count - 1);
>>> +    return sizeof(*idt) + sizeof(u32) * idt->line_count;
>>>   }
>>>     static bool add_idt(struct acpi_nfit_desc *acpi_desc,
>>