Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 27 Aug 2023 07:52:53 +0200
From:   Nicolas Schier <nicolas@fjasle.eu>
To:     Guru Das Srinagesh <quic_gurus@quicinc.com>
Cc:     Masahiro Yamada <masahiroy@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        Bjorn Andersson <andersson@kernel.org>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, Will Deacon <will@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        quic_pkondeti@quicinc.com, u.kleine-koenig@pengutronix.de,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 1/1] scripts: Add add-maintainer.py
Message-ID: <ZOrktcX1L6WHmLBi@fjasle.eu>
References: <cover.1691049436.git.quic_gurus@quicinc.com>
 <829b08342568735095bbd3f8c44f435f44688018.1691049436.git.quic_gurus@quicinc.com>
 <ZOYicEP8D7kNGFin@fjasle.eu>
 <20230824214436.GA22659@quicinc.com>
 <ZOiUOcMOeYvMzq58@bergen.fjasle.eu>
 <20230825170001.GB22659@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230825170001.GB22659@quicinc.com>
UI-OutboundReport: notjunk:1;M01:P0:pb8TgKev4sc=;b+LNStGfk+7SG1dylUYX4fWyXEd
 GbmjoydExqsKwip/t1r6MtoRY7AnqFmu9TNDE/nUN/xJLzo1tV6euglY0ZfYbSb4kOFwoFHKh
 IDOzWdcS9oYgfz5GqC3owEfMVj92Qj+/iFcMSGiJh46P+zl/sXpLbEsFlQ2YNdEJG5hgHX384
 43YHVrB//kpPGKhvJsDlLD7UxfbGR+Wi69Fothe6it4KdUSDpS5Uh5GfIk89QIBW6M0RrzhNh
 vi7d+OXCMIIMzabHWWfKJFGqKN5cvqp3nSlgivMCP5nWHu03gD6jKzdgRSN/Y15bi4NuSy5HQ
 12D2C1g5kBem/A8k/F8QYO3qMFlX2lGZycBftGe6pp4Go0YOS7dXDHUW+Rym9iesU5zlwqdQQ
 Gtk9sKmtvNV69WoQRHmCrdHyVWdE040og8Hjr/TnSRvUY6Y3l93+uhgdj96IkQwsZ2IHp2aJ+
 I6OJ1azevh+sppDxhvsGTpXIUBa3zKDzdb8WVg1EPqqTNo5ul0Yr04diXMXYI9o6syaLbJ+9B
 d4AUpB1oZvl/nboFTAPdo0iwyqkkfpKoqnh3ETd5yJC+aQE8Jg+S6j7AEmhSu8+jToES3jfUk
 iGlRAETOWyIwzqRVj00WpFNnGvfVqb9Al4asIRwXrr8KbbtzQYV/+hrLrYTZmSkdeeU9jzMLP
 Rs5HpSKn2c+9/dDb3W7u0mhLx6Ot0WFGmE4ERf6T4fmWGxaBB8UgNW1ysdSdn8lQcFt2wKHQx
 UG9j0htsw9TCJqfGXcbT9Z44xbUAVcmp6XtQMGSwQueKN83/wCNM7tFl0Syhdr8IrYfcs7JB6
 wRGeDNWUnsokLK7BdKfPWQq9eQ0djKw56yR+HenDPiBMbGRh4vnqmdE8AQ+//gSKOCbJ+wb9d
 r9dwLWIR7CxYN4g==
Precedence: bulk

On Fri, Aug 25, 2023 at 10:00:01AM -0700 Guru Das Srinagesh wrote:
> On Aug 25 2023 13:44, Nicolas Schier wrote:
> > On Thu 24 Aug 2023 14:44:36 GMT, Guru Das Srinagesh wrote:
> > > > While testing, I thought that adding addresses without filtering-out duplicates
> > > > was odd; but as git-send-email does the unique filtering, it doesn't matter.
> > > 
> > > Since I'm using `set()` in this script, the uniqueness is guaranteed here as
> > > well - there won't be any duplicates.
> > 
> > I thought about patch files that already have 'To/Cc' headers (e.g.  
> > 'git format-patch --to=... --cc=...' or by running add-maintainer.py 
> > multiple times for updating the lists of recipients.  The result is a 
> > patch file with possible duplicated lines; but as written: it does 
> > matter, effectively.
> 
> Sorry, did you mean "does" or "does *not*"?

I'm sorry, "it doe not matter".

Nicolas

> I'll make sure to test v3 of this script out on patches that have To/Cc already
> included and also run it multiple times on the same patch (effectively the same
> thing).
> 
> Thank you.
> 
> Guru Das.