Received: by 2002:a05:7412:1703:b0:e2:908c:2ebd with SMTP id dm3csp3112025rdb; Tue, 29 Aug 2023 05:59:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnNzikFGuLMDxrJ1LOksW62TsYYowbZiuPa2ORygSRK5vSSStoiH5DlwScN4ZwqTCDeOKo X-Received: by 2002:a05:6a00:2da9:b0:675:ef91:7922 with SMTP id fb41-20020a056a002da900b00675ef917922mr26085134pfb.4.1693313969973; Tue, 29 Aug 2023 05:59:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693313969; cv=none; d=google.com; s=arc-20160816; b=EljLX5qqFkWW1eq/g5VzWRzqqN9tx0rmyQYDDl/JkYlQiiDhuOFV0aiiZbwIKfVnOw Zfs2f61PbvI0ud7Hs7EQVceSWaZ90lJrPE8JTnLvXMdzv0ksz4lDny8jWTKaUmdrDEfp 0OBl54njecq5mNi0vwu7KGC4yB8vtCKh8ObG8x03ACSAmF7fCUfAs9YuYPZrspIYvSfn ep1skEW1mVR93oBS0oKxU+dY9n+8gdY3ldi+v8zcYubJpiUpkHKPnpuqug9pDEuwKSWx AEkg0Bc0VFhzFKeMz5sR1ZUNEnSljKIEesRRHfbplqQwyktGuMTwxhY7ek715xeTeq+L WD8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=PELaoVV7DrLQuw/lZUSO2dRCS1U1CaoichWPb1NElTg=; fh=2Mm1KB7knhrAMfYif+uhSrhkAQXn8RsEjmxFzqclt9Q=; b=s/HuNsMtcyjhjgrn9RMxBHpNu4fDujQUSmI+/mRUCGiiE+F3a1FcELCYRLzDZaBf6B qhUQ04lmLAG0S7hga21Arr1ESOG5dJEqoUEXvnm/Gic/XBbj8DPbXqmYGB3vfmqza383 iYBwABAtKLFRhYot9s4SBbABNDYghBZ9t6wGd0gpOZ+0wlYvVFkQdTnvDKOZyOja2ZVy UOgxn1+GsKfK4RND5PAvIevV9mgC6Qf6AYxIXB57TeQnUiSsQLlv8nbdvydm6SlQiSJv oP9CreOK7sogOH/jGqayoScWP+/I4TrN5j0SmNEhP7rCwVKdeU2qjZ6RJL9gvHr5qAp3 PhTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=mpIHSsXq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k3-20020a6568c3000000b00565f0e91894si9376429pgt.394.2023.08.29.05.59.09; Tue, 29 Aug 2023 05:59:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=mpIHSsXq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231640AbjH2LW6 (ORCPT + 99 others); Tue, 29 Aug 2023 07:22:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231975AbjH2LWl (ORCPT ); Tue, 29 Aug 2023 07:22:41 -0400 Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2899FEC; Tue, 29 Aug 2023 04:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PELaoVV7DrLQuw/lZUSO2dRCS1U1CaoichWPb1NElTg=; b=mpIHSsXqZ4rZGh/CuOhBIfWINX 4ECohFkyxlPwfm2JVgHB3l1f74zk0rtZvaBaLrkD0qEw5xRRz+LyjqEP82k2ACDwODPvJgOflO5Mn 08NaEDIHMdsZEVrhYVxJW2EZdgAKCUrt0lGfXHluZ77fTCTJKSCd5pcMwXzZV68sljBg6rD89SL6Z 2LF91nyxSuXzQCwR3nunWdownszEM6gjvXbHw46muymwLS+cuWA8oruoey7Qz3ZMPbiymHE82hdnl hXsNKOrj+Im/OWSZOcSa9+NjYtJuGq4XLmONtTDhgU3QOTouo83KhJKbF7exisFdVQD9rddqGtVcq 6h3dHBzw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55738) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qawmw-0000OF-38; Tue, 29 Aug 2023 12:21:39 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qawmn-0004bN-Q4; Tue, 29 Aug 2023 12:21:29 +0100 Date: Tue, 29 Aug 2023 12:21:29 +0100 From: "Russell King (Oracle)" To: Jisheng Zhang Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Emil Renner Berthing , Samin Guo , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Jonathan Hunter , Nobuhiro Iwamatsu , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 00/22] convert to devm_stmmac_probe_config_dt Message-ID: References: <20230829104033.955-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230829104033.955-1-jszhang@kernel.org> Sender: Russell King (Oracle) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 29, 2023 at 06:40:11PM +0800, Jisheng Zhang wrote: > Russell pointed out there's a new devm_stmmac_probe_config_dt() > helper now when reviewing my starfive gmac error handling patch[1]. > After greping the code, this nice helper was introduced by Bartosz in > [2], I think it's time to convert all dwmac users to this helper and > finally complete the TODO in [2] "but once all users of the old > stmmac_pltfr_remove() are converted to the devres helper, it will be > renamed back to stmmac_pltfr_remove() and the no_dt function removed." I think a useful final patch may be to make stmmac_probe_config_dt() static so there aren't any new uses of stmmac_probe_config_dt(). Also note that net-next is now closed, so please wait until after -rc1 for net-next to re-open, or post as RFC. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!