Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Aug 2023 11:22:30 +0300
From:   Pekka Paalanen <ppaalanen@gmail.com>
To:     Jessica Zhang <quic_jesszhan@quicinc.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Clark <robdclark@gmail.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        "Sean Paul" <sean@poorly.run>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        <quic_abhinavk@quicinc.com>, <contact@emersion.fr>,
        <laurent.pinchart@ideasonboard.com>, <sebastian.wick@redhat.com>,
        <ville.syrjala@linux.intel.com>, <dri-devel@lists.freedesktop.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <freedreno@lists.freedesktop.org>,
        <wayland-devel@lists.freedesktop.org>
Subject: Re: [PATCH RFC v6 07/10] drm/atomic: Loosen FB atomic checks
Message-ID: <20230829112230.7106a8bf@eldfell>
In-Reply-To: <20230828-solid-fill-v6-7-a820efcce852@quicinc.com>
References: <20230828-solid-fill-v6-0-a820efcce852@quicinc.com>
        <20230828-solid-fill-v6-7-a820efcce852@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/H5g8wKc5R4arUhKQdvg=lAj";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/H5g8wKc5R4arUhKQdvg=lAj
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Mon, 28 Aug 2023 17:05:13 -0700
Jessica Zhang <quic_jesszhan@quicinc.com> wrote:

> Loosen the requirements for atomic and legacy commit so that, in cases
> where pixel_source !=3D FB, the commit can still go through.
>=20
> This includes adding framebuffer NULL checks in other areas to account for
> FB being NULL when non-FB pixel sources are enabled.
>=20
> To disable a plane, the pixel_source must be NONE or the FB must be NULL
> if pixel_source =3D=3D FB.
>=20
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
>  drivers/gpu/drm/drm_atomic.c        | 20 +++++++++++---------
>  drivers/gpu/drm/drm_atomic_helper.c | 36 ++++++++++++++++++++-----------=
-----
>  include/drm/drm_atomic_helper.h     |  4 ++--
>  include/drm/drm_plane.h             | 29 +++++++++++++++++++++++++++++
>  4 files changed, 62 insertions(+), 27 deletions(-)

...

> diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
> index a58f84b6bd5e..4c5b7bcdb25c 100644
> --- a/include/drm/drm_plane.h
> +++ b/include/drm/drm_plane.h
> @@ -992,6 +992,35 @@ static inline struct drm_plane *drm_plane_find(struc=
t drm_device *dev,
>  #define drm_for_each_plane(plane, dev) \
>  	list_for_each_entry(plane, &(dev)->mode_config.plane_list, head)
> =20
> +/**
> + * drm_plane_solid_fill_enabled - Check if solid fill is enabled on plane
> + * @state: plane state
> + *
> + * Returns:
> + * Whether the plane has been assigned a solid_fill_blob
> + */
> +static inline bool drm_plane_solid_fill_enabled(struct drm_plane_state *=
state)
> +{
> +	if (!state)
> +		return false;
> +	return state->pixel_source =3D=3D DRM_PLANE_PIXEL_SOURCE_SOLID_FILL && =
state->solid_fill_blob;
> +}
> +
> +static inline bool drm_plane_has_visible_data(const struct drm_plane_sta=
te *state)
> +{
> +	switch (state->pixel_source) {
> +	case DRM_PLANE_PIXEL_SOURCE_NONE:
> +		return false;
> +	case DRM_PLANE_PIXEL_SOURCE_SOLID_FILL:
> +		return state->solid_fill_blob !=3D NULL;

This reminds me, new UAPI docs did not say what the requirements are for
choosing solid fill pixel source. Is the atomic commit rejected if
pixel source is solid fill, but solid_fill property has no blob?

This should be doc'd.


Thanks,
pq

> +	case DRM_PLANE_PIXEL_SOURCE_FB:
> +	default:
> +		WARN_ON(state->pixel_source !=3D DRM_PLANE_PIXEL_SOURCE_FB);
> +	}
> +
> +	return state->fb !=3D NULL;
> +}
> +
>  bool drm_any_plane_has_format(struct drm_device *dev,
>  			      u32 format, u64 modifier);
> =20
>=20


--Sig_/H5g8wKc5R4arUhKQdvg=lAj
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAmTtqsYACgkQI1/ltBGq
qqeTog/8Dv877MsYgD2yMEFq4iy4cM+PK7kLDTvDtGCBUI7yDeFvqA46SuALLBp2
R0f6Lm3HkKZjCIcZ2LZZZSiESJCd9KFqoxyqj1dFYtdcUOO1iKISvzXeZJHGb7Qs
BtjsFYtOGPFE91O+xonH4/UqDHNfZeQ8tCmFMNK7Lw/iaqyCUE5RPQFvDjFOqMAy
t2BMaQntcKhr4KjIxWgS8n1isaPI/h4hNEzc/WS8rEwblubaamJr8UWQsvtV3sJd
wCbJHAhMsORQjE15xm6siGTp/x2q9HUjbuDUUvEa+lO9owpXrJPucGMAyhf4flwN
FOftM6kAYy7+Nu2RxYPzO086JsyGoUnxzIdrlBn5Qq/5a/RfdUosXJYYFPr7tWVC
CjEJBonNvLLK0QW/mnGs+yD8BoPKp6qI/CbCe1nQhrOWPKSakzpF2DfWmeOmd7bZ
Kn2xsqNTPZSn6ZE/8HDvtlUloktwJPKvyS1dBZ025YlIBi17exLVwBQREYTVZSS0
GS9J7h9blKD9I0H/c6vrQpf5wa93SVRka/52LBeNRU82ReaTQyRNH7QFpbIJqvdc
zXW5oFeQqdBFbZcxB8SGIyYYNLGbwn7/vKbntRcB7GCh/dQAsXIewODNVbGXCa9b
IgRToTt7i//LwFFH4Uw1+3zNqjuK7SinpSs7ni611esewEEySR8=
=NP0j
-----END PGP SIGNATURE-----

--Sig_/H5g8wKc5R4arUhKQdvg=lAj--