Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d5ef27f1-9e6d-5e3c-b7ea-4b0abca623ed@arm.com>
Date:   Tue, 29 Aug 2023 16:28:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] dma/pool: trivial: add semicolon after label
 attributes
Content-Language: en-GB
To:     Christoph Hellwig <hch@lst.de>
Cc:     Chunhui He <hchunhui@mail.ustc.edu.cn>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20230826085317.69713-1-hchunhui@mail.ustc.edu.cn>
 <6f936d6e-9f27-ba72-68de-0ed27c0dbbe1@arm.com> <20230829151216.GA4211@lst.de>
From:   Robin Murphy <robin.murphy@arm.com>
In-Reply-To: <20230829151216.GA4211@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 29/08/2023 4:12 pm, Christoph Hellwig wrote:
> On Tue, Aug 29, 2023 at 03:22:22PM +0100, Robin Murphy wrote:
>> AFAICS, what that clearly says is that *C++* label attributes can be
>> ambiguous. This is not C++ code. Even in C11, declarations still cannot be
>> labelled, so it should still be the case that, per the same GCC
>> documentation, "the ambiguity does not arise". And even if the language did
>> allow it, an inline declaration at that point at the end of a function
>> would be downright weird and against the kernel coding style anyway.
>>
>> So, I don't really see what's "better" about cluttering up C code with
>> unnecessary C++isms; it's just weird noise to me. The only thing I think it
>> *does* achieve is introduce the chance that the static checker brigade
>> eventually identifies a redundant semicolon and we get more patches to
>> remove it again.
> 
> Agreed.  Even more importantly that attribute looks rather questionable
> to start with as it can be dropped by just moving the #endif a little:
> 
> diff --git a/kernel/dma/pool.c b/kernel/dma/pool.c
> index 1acec2e228273f..da03c4a57cebe3 100644
> --- a/kernel/dma/pool.c
> +++ b/kernel/dma/pool.c
> @@ -135,8 +135,8 @@ static int atomic_pool_expand(struct gen_pool *pool, size_t pool_size,
>   remove_mapping:
>   #ifdef CONFIG_DMA_DIRECT_REMAP
>   	dma_common_free_remap(addr, pool_size);
> +free_page:
>   #endif
> -free_page: __maybe_unused
>   	__free_pages(page, order);
>   out:
>   	return ret;

Oh, indeed - I hadn't really looked at the context itself. My 
non-exhaustive grep skills show a couple of hundred instances of 
label-above-#endif vs. three (!) instances of __maybe_unused, so ack to 
making that cleanup to just remove the question entirely.

Cheers,
Robin.