Received: by 2002:a05:7412:1703:b0:e2:908c:2ebd with SMTP id dm3csp3334540rdb; Tue, 29 Aug 2023 12:03:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHwVyKSYLgGUm7HHTV2ue2QfpJ7DAThd4phnW/AuONcQqZMWCfrARbGr5+sPUv1BWxyrNV4 X-Received: by 2002:a05:6a20:4303:b0:148:9ce9:2f2a with SMTP id h3-20020a056a20430300b001489ce92f2amr207373pzk.8.1693335783795; Tue, 29 Aug 2023 12:03:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693335783; cv=none; d=google.com; s=arc-20160816; b=mV57V7ElkHqK2Mf0/WDf9C3IV3TVyZc5rSrg4t0nTDHS9LcfrOO5jt67C7+FRkC7e8 CSyPyPZn5WuMTndnyUUHIcN19w/Q+LfZVsXhKPF0FK0Am3YRYpJwD4/N9Z1HlXlVnEWe HocSWpAE+Dgs1gxc1ttQF25+VLqBOeaeHVTPpZonnTR9n9NxryCUI/cv1iqfhXtq4KZj P7DiTLxKuzFzYTm4OjA/Zx5Bwi/z0dR9vbP2xJY6y7eSikOpNTk2UdD7iA6a9yPZPwgK oL+fWL5QN47JpJd+msCT4ysUNeKr9bAlohCW/C3uyHU3JGwJTtUX5twMnEyJZLk5B6AK y3Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=D6lbZ5EY1B6HKU357oK07CIHfD+KpnFLfZHleBsYkNg=; fh=xul8u5lbFhEjS9WSOKDxePiEh0mLhT/NsGR/umN2l24=; b=yXeajyYl2+/V3bDynqK060NiGUGJS42TmlnpVGrRsf4IFzq4UHOvVO5dZfSOHf5ez1 xU2ivb9kTDyJJ/rjtqoHWOsIVCoPKavHpr3PIbXNwB/S9ZUn+yoSN03Irdo34N1iglEl R+PECOEZGPsb8FQKfiOP+S2sLVEV/XbzE0vgVf8t2kYgaaEQOpuvrTNp0+kwMiSinJpo Z+NrvQQd0oK8E57HjORYFIpnQo1C0bPfmEK8TL1JGd+J1z7jG2R9bUOFU1rIkXwCVQb8 rUg9zpbrIpy0U40LR4Nwvn0KYykdOwz6cTj5A9ekpLby+MQGXrqSzJqb6BBnzlmjAbhS LGMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b8-20020a056a000cc800b0068a3a7f88f9si395125pfv.128.2023.08.29.12.02.46; Tue, 29 Aug 2023 12:03:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237061AbjH2PGa (ORCPT + 99 others); Tue, 29 Aug 2023 11:06:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237183AbjH2PGU (ORCPT ); Tue, 29 Aug 2023 11:06:20 -0400 Received: from outbound-smtp37.blacknight.com (outbound-smtp37.blacknight.com [46.22.139.220]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27017C9 for ; Tue, 29 Aug 2023 08:06:12 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp37.blacknight.com (Postfix) with ESMTPS id 028E61B86 for ; Tue, 29 Aug 2023 16:06:10 +0100 (IST) Received: (qmail 8158 invoked from network); 29 Aug 2023 15:06:09 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.20.191]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 29 Aug 2023 15:06:09 -0000 Date: Tue, 29 Aug 2023 16:06:07 +0100 From: Mel Gorman To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, david@redhat.com, willy@infradead.org Subject: Re: [PATCH v2 6/7] mm/compaction: improve comment of is_via_compact_memory Message-ID: <20230829150607.p4qyjsvrovdhhnh6@techsingularity.net> References: <20230826153617.4019189-1-shikemeng@huaweicloud.com> <20230826153617.4019189-7-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230826153617.4019189-7-shikemeng@huaweicloud.com> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 26, 2023 at 11:36:16PM +0800, Kemeng Shi wrote: > We do proactive compaction with order == -1 via > 1. /proc/sys/vm/compact_memory > 2. /sys/devices/system/node/nodex/compact > 3. /proc/sys/vm/compaction_proactiveness > Add missed situation in which order == -1. > > Signed-off-by: Kemeng Shi Acked-by: Mel Gorman -- Mel Gorman SUSE Labs