Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     Tony Lindgren <tony@atomide.com>, Lee Jones <lee@kernel.org>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] mfd: palmas: Make similar OF and ID table
Thread-Topic: [PATCH v2 2/2] mfd: palmas: Make similar OF and ID table
Thread-Index: AQHZ2cTJkhjA2pJYZUWMs/kEqnV/j7ABW6AAgAABQMA=
Date:   Tue, 29 Aug 2023 14:51:30 +0000
Message-ID: <OS0PR01MB5922DC4C709B3A6AE891423A86E7A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20230828153144.75479-1-biju.das.jz@bp.renesas.com>
 <20230828153144.75479-3-biju.das.jz@bp.renesas.com>
 <ZO4EwAgDU0yefC/t@smile.fi.intel.com>
In-Reply-To: <ZO4EwAgDU0yefC/t@smile.fi.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?U6cC9Z1A1PLzYj2k/89Y18oItcam7QZdyWliBLP8VE3GcLlXK4EU3H+KR/hu?=
 =?us-ascii?Q?nnmf4s4NW+xe8YSXwcpP0rdEj//27aEdIlwlzC5REZzAC9K17CzZUWyqY5py?=
 =?us-ascii?Q?Mm7eLKD5bRixRFSRSp5FH61G5vkBODUHSsrVslfPaZt6RwbmCh45v4L1Kyhu?=
 =?us-ascii?Q?xCGwrrH2QJ86XV/cVXZ8gRlX6V7rWVyY/kv5zfGl0Th1kpfGujAkngyTw6ZL?=
 =?us-ascii?Q?2hiSmrRw/92vCQdECir1nKCfCG01kI5En9NDZ4ljhskO+gQENP3I1+1VCaEs?=
 =?us-ascii?Q?oFuTQ4Nut5pTZjqenzJnKuyZK1SMQWutUg8E/96ki1cJWZZO07pgPlCUbZHd?=
 =?us-ascii?Q?4+CyF/0UWg1Caxrx0/dzERLAKMHG9tBz7dxF/h57cSCtg22QM3jkcpod41s6?=
 =?us-ascii?Q?LPfsBRCutBy7IrK02oTUeHtoaCimbGbaY8JJpgdy9ynnx2eGn9PDr/owT+ho?=
 =?us-ascii?Q?YmSL4Z68bQ+Kio7uleUvpdfVW9GSaHo/Ze5iy9VO9oeatFtEIf2o+acHVXd8?=
 =?us-ascii?Q?sfJ4oKwNpyJycoJGOlOOK2NVxbBWFXHn5aL6+G5CGseVlb4G1N2harNpdwaj?=
 =?us-ascii?Q?ijojEUXndQbENhHjlKUcJd88PCT7xK/gLiHF1QaJwW4aU9FQLjknYLIuPjgY?=
 =?us-ascii?Q?Ft4/Oyk8X2hhTxD+LH46OgA//rf+sFXLJTLFaXs44RDZpAzfrTN/F3Nat6yq?=
 =?us-ascii?Q?Mkt0C4GrVoW9fHzC6yaHw0QGlb2G2TTOK4EQ0rPm5FPyLh6czO64JJHk6/yQ?=
 =?us-ascii?Q?YWGoGy8UhhUQhKUSvomI3njDuBxYXzqjSw2t77lUGnl5rNz8M1nYYTxbDnnw?=
 =?us-ascii?Q?p3nu4VpSM+f9qdt9WguaC5sRpSY3WMtjnKFaXsBfBDvG1zR+bLVi/a1OCdJx?=
 =?us-ascii?Q?vrnRRVwx+epzYS36rl8RS9psDsD50U4afObg80KYJw7RC2qJyaqhpw8RhvY9?=
 =?us-ascii?Q?B1kaF6LiXBr/aCgmzs1O3Fd+XRITEArhbGsC0cC4AIGqxmSLGyfLr6b2Mv/X?=
 =?us-ascii?Q?HZPfAYlGhBu6pjIEdG9k9d/5dPjECcAEe8Fn9BepIOfSlOg+FZZLacKjpV2H?=
 =?us-ascii?Q?Xa0HxTPVorxf9LpCClOFiT17iMClrcVlVnAKa5DS3UEKCHRSF4d1uuDXTG9a?=
 =?us-ascii?Q?NycoGKD3XUzCtwRulnRodxGgqy2TfuDIKIBBI636aFFyKrSd87NL0hykK+qI?=
 =?us-ascii?Q?WylOBG0/D4lerlJZxi+99mslZNRVpHDvFrA1AT3wAnbjM0E+aFg5n4OmiZTy?=
 =?us-ascii?Q?7qVxuk+cRBgaH0F9Z6AdhbMWnPM++C8IeDPzMtJ9bELR3PDSt3HVuUuRwH19?=
 =?us-ascii?Q?pS2JpFAxMoY2M1JNTX6bDOusMIxgID03TJXzMc+nlpYaui2VTE8FvHfOQK7A?=
 =?us-ascii?Q?NUyuWUJSE3D8C5Zd5EyQPrdZa/G0NctvrMXFivLX2Xhsd747R1/9Z4RjHF5O?=
 =?us-ascii?Q?gD7lupCnlD3fEuXleDtO3l2VoSUUdG5BLEUW05+Nr8qA6/pRN+8OuUxkwLf8?=
 =?us-ascii?Q?tfBWD7IckDLawJJ9pnK6bQnTDEZVhFHwcOC7/Wc5r2D+xN1sNqucOe9ApvF2?=
 =?us-ascii?Q?3IQjSgfLnp+Mqw/iGkg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bc34ef3-9c58-4b02-b2f5-08dba89f6e49
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2023 14:51:30.6623
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: r/8pOYPeJuP5fm8zr3OeaAvtI0OOUwy4nxcBRz74Aaaz/8G1UDZesoK5vi9JdtXkuFqQwQpFDEAqL3Bq3Q0+6TUMo6Z/IM5GxzFTsLrRqGM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB8539
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy Shevchenko,

> Subject: Re: [PATCH v2 2/2] mfd: palmas: Make similar OF and ID table
>=20
> On Mon, Aug 28, 2023 at 04:31:44PM +0100, Biju Das wrote:
> > Make similar OF and ID table to extend support for ID match using
> > i2c_match_data(). Currently it works only for OF match tables as the
> > driver_data is wrong for ID match.
>=20
> ...
>=20
> > While at it, drop the inner leading commas for ID  table.
>=20
> Are you sure?

Oops. Will drop it.

Cheers,
Biju

>=20
> ------------------v
> > -	{ "palmas", },
> > -	{ "twl6035", },
> > -	{ "twl6037", },
> > -	{ "tps65913", },
> > +	{ "palmas", (kernel_ulong_t)&palmas_data },
> > +	{ "twl6035", (kernel_ulong_t)&palmas_data },
> > +	{ "twl6037", (kernel_ulong_t)&palmas_data },
> > +	{ "tps65913", (kernel_ulong_t)&palmas_data },
>=20
> --
> With Best Regards,
> Andy Shevchenko
>=20