Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9e3fec3f3bf11ec0722f6277593d96ff.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230829095423.760641-3-quic_gokulsri@quicinc.com>
References: <20230829095423.760641-1-quic_gokulsri@quicinc.com> <20230829095423.760641-3-quic_gokulsri@quicinc.com>
Subject: Re: [PATCH 2/3] clk: qcom: apss-ipq-pll: add support for IPQ5018
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     quic_varada@quicinc.com, quic_srichara@quicinc.com,
        quic_gokulsri@quicinc.com
To:     Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com>,
        agross@kernel.org, andersson@kernel.org,
        devicetree@vger.kernel.org, jassisinghbrar@gmail.com,
        konrad.dybcio@linaro.org, krzysztof.kozlowski+dt@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, mturquette@baylibre.com,
        robh+dt@kernel.org
Date:   Tue, 29 Aug 2023 15:34:34 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Gokul Sriram Palanisamy (2023-08-29 02:54:22)
> diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-=
pll.c
> index e170331858cc..bbc25d5eb70d 100644
> --- a/drivers/clk/qcom/apss-ipq-pll.c
> +++ b/drivers/clk/qcom/apss-ipq-pll.c
> @@ -24,6 +24,17 @@ static const u8 ipq_pll_offsets[][PLL_OFF_MAX_REGS] =
=3D {
>                 [PLL_OFF_TEST_CTL] =3D 0x30,
>                 [PLL_OFF_TEST_CTL_U] =3D 0x34,
>         },
> +       [CLK_ALPHA_PLL_TYPE_STROMER] =3D {
> +               [PLL_OFF_L_VAL] =3D 0x08,
> +               [PLL_OFF_ALPHA_VAL] =3D 0x10,
> +               [PLL_OFF_ALPHA_VAL_U] =3D 0x14,
> +               [PLL_OFF_USER_CTL] =3D 0x18,
> +               [PLL_OFF_USER_CTL_U] =3D 0x1c,
> +               [PLL_OFF_CONFIG_CTL] =3D 0x20,
> +               [PLL_OFF_STATUS] =3D 0x28,
> +               [PLL_OFF_TEST_CTL] =3D 0x30,
> +               [PLL_OFF_TEST_CTL_U] =3D 0x34,
> +       },

Is anything different from STROMER_PLUS?

>         [CLK_ALPHA_PLL_TYPE_STROMER_PLUS] =3D {
>                 [PLL_OFF_L_VAL] =3D 0x08,
>                 [PLL_OFF_ALPHA_VAL] =3D 0x10,
> @@ -73,6 +84,38 @@ static struct clk_alpha_pll ipq_pll_stromer_plus =3D {
>         },
>  };
> =20
> +static struct clk_alpha_pll ipq_pll_stromer =3D {
> +       .offset =3D 0x0,
> +       .regs =3D clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_STROMER],
> +       .flags =3D SUPPORTS_DYNAMIC_UPDATE,
> +       .clkr =3D {
> +               .enable_reg =3D 0x0,
> +               .enable_mask =3D BIT(0),
> +               .hw.init =3D &(struct clk_init_data){

const?

> +                       .name =3D "a53pll",
> +                       .parent_data =3D &(const struct clk_parent_data) {
> +                               .fw_name =3D "xo",
> +                       },
> +                       .num_parents =3D 1,
> +                       .ops =3D &clk_alpha_pll_stromer_ops,
> +               },
> +       },
> +};
> +
> +static const struct alpha_pll_config ipq5018_pll_config =3D {
> +       .l =3D 0x32,
> +       .config_ctl_val =3D 0x4001075b,
> +       .config_ctl_hi_val =3D 0x304,
> +       .main_output_mask =3D BIT(0),
> +       .aux_output_mask =3D BIT(1),
> +       .early_output_mask =3D BIT(3),
> +       .alpha_en_mask =3D BIT(24),
> +       .status_val =3D 0x3,
> +       .status_mask =3D GENMASK(10, 8),
> +       .lock_det =3D BIT(2),
> +       .test_ctl_hi_val =3D 0x00400003,
> +};
> +
>  static const struct alpha_pll_config ipq5332_pll_config =3D {
>         .l =3D 0x3e,
>         .config_ctl_val =3D 0x4001075b,
> @@ -129,6 +172,12 @@ struct apss_pll_data {
>         const struct alpha_pll_config *pll_config;
>  };
> =20
> +static struct apss_pll_data ipq5018_pll_data =3D {

const?

> +       .pll_type =3D CLK_ALPHA_PLL_TYPE_STROMER,
> +       .pll =3D &ipq_pll_stromer,
> +       .pll_config =3D &ipq5018_pll_config,
> +};
> +
>  static struct apss_pll_data ipq5332_pll_data =3D {
>         .pll_type =3D CLK_ALPHA_PLL_TYPE_STROMER_PLUS,
>         .pll =3D &ipq_pll_stromer_plus,
> @@ -183,7 +232,7 @@ static int apss_ipq_pll_probe(struct platform_device =
*pdev)
> =20
>         if (data->pll_type =3D=3D CLK_ALPHA_PLL_TYPE_HUAYRA)
>                 clk_alpha_pll_configure(data->pll, regmap, data->pll_conf=
ig);
> -       else if (data->pll_type =3D=3D CLK_ALPHA_PLL_TYPE_STROMER_PLUS)
> +       else

Just add both STROMER and STROMER_PLUS. Or make STROMER the same as
STROMER_PLUS locally in this file?

>                 clk_stromer_pll_configure(data->pll, regmap, data->pll_co=
nfig);
> =20
>         ret =3D devm_clk_register_regmap(dev, &data->pll->clkr);