Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   SeongJae Park <sj@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     SeongJae Park <sj@kernel.org>, damon@lists.linux.dev,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mm/damon/core: add a tracepoint for damos apply target regions
Date:   Wed, 30 Aug 2023 01:36:21 +0000
Message-Id: <20230830013621.46216-1-sj@kernel.org>
In-Reply-To: <20230829191629.25c5f0e2@rorschach.local.home>
References: 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Steven,

On Tue, 29 Aug 2023 19:16:29 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:

> On Sun, 27 Aug 2023 00:40:45 +0000
> SeongJae Park <sj@kernel.org> wrote:
> 
> > +	TP_STRUCT__entry(
> > +		__field(unsigned int, context_idx)
> 
> 4 bytes
> 
> > +		__field(unsigned int, scheme_idx)
> 
> 4 bytes
> 
> > +		__field(unsigned long, target_idx)
> 
> 8 bytes
> 
> > +		__field(unsigned int, nr_regions)
> 
> 4 bytes
> 
> > +		__field(unsigned long, start)
> 
> This is going to cause a 4 byte hole. I would move nr_regions after end
> so that it stays properly aligned.

That makes sense, thank you for letting me know this!  I will do so in the next
spin.


Thanks,
SJ

> 
> -- Steve
> 
> 
> 
> > +		__field(unsigned long, end)
> > +		__field(unsigned int, nr_accesses)
> > +		__field(unsigned int, age)
> > +	),
> > +
>