Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Aug 2023 16:10:28 +0300
From:   "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>
To:     "Huang, Kai" <kai.huang@intel.com>
Cc:     "Hansen, Dave" <dave.hansen@intel.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "x86@kernel.org" <x86@kernel.org>, "bp@alien8.de" <bp@alien8.de>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "sathyanarayanan.kuppuswamy@linux.intel.com" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        "n.borisov.lkml@gmail.com" <n.borisov.lkml@gmail.com>
Subject: Re: [PATCH v4 07/12] x86/tdx: Make TDX_HYPERCALL asm similar to
 TDX_MODULE_CALL
Message-ID: <20230830131028.lbtwtefap7khvt44@box.shutemov.name>
References: <cover.1692096753.git.kai.huang@intel.com>
 <0cbf25e7aee3256288045023a31f65f0cef90af4.1692096753.git.kai.huang@intel.com>
 <20230825233558.xzqukr3vbccii7f4@box>
 <1a40b4dc8d155618723671685e7ad53e3fce0aa4.camel@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1a40b4dc8d155618723671685e7ad53e3fce0aa4.camel@intel.com>
Precedence: bulk

On Sat, Aug 26, 2023 at 12:50:11AM +0000, Huang, Kai wrote:
> On Sat, 2023-08-26 at 02:35 +0300, kirill.shutemov@linux.intel.com wrote:
> > On Tue, Aug 15, 2023 at 11:02:01PM +1200, Kai Huang wrote:
> > > +	/*
> > > +	 * Failure of __tdcall_hypercall() indicates a failure of the TDVMCALL
> > > +	 * mechanism itself and that something has gone horribly wrong with
> > > +	 * the TDX module.  __tdx_hypercall_failed() never returns.
> > > +	 */
> > > +	if (__tdcall_hypercall(TDG_VP_VMCALL, &margs))
> > > +		__tdx_hypercall_failed();
> > 
> > Do we even need __tdx_hypercall_failed() anymore? Just call panic()
> > directly, no?
> > 
> 
> __tdx_hypercall() is currently annotated with 'noinstr' (which is also the
> behaviour of the old code).  We need it otherwise we will get build warning like
> below:
> 
> https://lore.kernel.org/lkml/a23ce8fd289141cea3a1b4f3dace221dca847238.camel@intel.com/T/#m205b29ce3e33983ec6be733c2afffbfd5cb653ff

Okay, fair enough. We can return back to it later.

Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
  Kiryl Shutsemau / Kirill A. Shutemov