Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Aug 2023 10:53:58 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Tony Luck <tony.luck@intel.com>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Peter Newman <peternewman@google.com>,
        "Jonathan Corbet" <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>, <x86@kernel.org>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <patches@lists.linux.dev>
Subject: Re: [PATCH v5 1/8] x86/resctrl: Prepare for new domain scope
Message-ID: <bssbtlnjbytqoraiamg7igvawtmlnimzthud5mlacbmjotivhj@hrrabdpmkbjx>
References: <20230722190740.326190-1-tony.luck@intel.com>
 <20230829234426.64421-1-tony.luck@intel.com>
 <20230829234426.64421-2-tony.luck@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230829234426.64421-2-tony.luck@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?0grj6J9ZqdyFUACjgDOdxrp/IROAdwWQqXY2CKX8091lOFgDtkE6EFjiLO?=
 =?iso-8859-1?Q?jpSalQKzfzqd51ScFAVsr8eIiGRUePn341EWAMCdIz08ZKtGUZQUYm6GAt?=
 =?iso-8859-1?Q?CN+jIcy75EbGUaQF+prLDU1wlgbuqkbHpwEOXqHsNZUYIoLlvnJCLDPSF2?=
 =?iso-8859-1?Q?XmKNxxW3RnLGDWLHCypP1Y5i3yPxjd4ypWcn1m2pF/YWr8WpBFLJFCb94N?=
 =?iso-8859-1?Q?iQrzDKapJ6PrDE8yIAmbsK7UT+onFyg8gI3kUqeuexQamQhR7Z5eubWFHW?=
 =?iso-8859-1?Q?RUv74Rzl3ldZjjvXbtFH36eegGoBl8zsJe9kDBFWV6/W+YiKNTWnJB09kM?=
 =?iso-8859-1?Q?zfYLHbBbun/p00RRDcwvTajYEb950PXAEXyu9CSGQo8iCrxbRF/aoxxHPN?=
 =?iso-8859-1?Q?vE+z/2YGN1NBq5joE8n0EXPA/VzOMLYrULf/rRabvHZVgFA5Wf6iby5lwD?=
 =?iso-8859-1?Q?4sxwJTbc7jFM8Y3p2+4YtqoFvv7KXInND8QpGn/LR0rxxfSqLiqmAxCQkh?=
 =?iso-8859-1?Q?CvZM1zi7xPVl3QqWwUxDLj8M5qN2ElvFQmnS57L8TotMvJEq3ZlKzRmMSN?=
 =?iso-8859-1?Q?7coYa9P3GhAvu4yELXCecH3T2NuU0xud7xKyW1zDtEPuphGpl8TRsZaWNG?=
 =?iso-8859-1?Q?qcBBh8sTk6Qiyvrct61eUXHc8CWj63IIxDDrvuu1RzcsV5OX1CQVOFOWqe?=
 =?iso-8859-1?Q?9Uw7vijz2I6HzXSFxpqOohXhJ+RhL5VF1XPjlh/LDNqJQV+5HjYg4+Ikf/?=
 =?iso-8859-1?Q?sqCWfwwZuXCc5gMHByU61sQiXdrA26bISLKQ6KMkHVIBUAdDD2npluqwE6?=
 =?iso-8859-1?Q?4TQBz3EvfkMgD+KX13BhlWbYavQKYieoksorzYKNU6h3IfZkCHIUFs3+sm?=
 =?iso-8859-1?Q?O5HsUtOtilAamcJDXtiuP11zNBmxahUnZGOAMHX1mIBhkvS6bZ/bvRcGs4?=
 =?iso-8859-1?Q?nAMGmUZ6S81vw52hS3za4Nmr+/ypmkpLteTZvZIvxSx+pPJI8JJJJIlZeu?=
 =?iso-8859-1?Q?RiG2EUVh+ZSnNxWH9Vkvan56GSWYCXPUBIGdAMvZs2p4h5uJQDcEGG0e+u?=
 =?iso-8859-1?Q?LiADzeFsVYK/b265b8tUE/JxrBotj+73zOyynLnoZzaTh1imf4Z/E1aRNT?=
 =?iso-8859-1?Q?74mN2mcrWhVYDfJVWkKcMECgVNY1A3H7RE91Bsc0gL6pvwfs/xOOLjslBo?=
 =?iso-8859-1?Q?xT0Lpdx1k7Es4zxWX6CueJ+Z8qVLw+kCEYJLp5GehEz0xBe2j/H4poGOLZ?=
 =?iso-8859-1?Q?qv1YRWZ74kyKvF1dwuUs/K7+/VaAc4x5YFHem3vd5PGVyl9x1SW5NMGO0H?=
 =?iso-8859-1?Q?ecbsw9OyCHi4P0/QnOyxW5wADBSEZvt+NDJ0T5KdZUAWST5baSe+ktptBv?=
 =?iso-8859-1?Q?F8uQbgKHCMTzG2WgbLFWOsOu/RLEzT5ybLNyCIDSGoim47PIkjIT0g0iyK?=
 =?iso-8859-1?Q?ctrTen4RDxIY8R0xRAsphNYEX/v9gTgMLmp7L0/2B0DvTG0VmkKNRv9Vhb?=
 =?iso-8859-1?Q?/PRBYgk4Ue7jcoSV11H7xVWkPoOHY/+6F1eiSGzSCO9oVMxAqWQ0qBEBkd?=
 =?iso-8859-1?Q?j9GjxfHdSMz7vSvOrfbOmn62/cojtP4dJodWBvIAyatjswjrfMXcslJyB2?=
 =?iso-8859-1?Q?2XvgBxitZyBorknYO9JSivVjCxOFdTs1r6o6PYGIX67oM/GmKZ0VCOHh6s?=
 =?iso-8859-1?Q?TMZ6jr3DMZEQtwEF40k=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c8bc0731-7c52-414f-5d98-08dba936acf5
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2023 08:54:10.3281
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bJuf/N7jf4Jdqvxz9jvh7SOVCeNaL+Qhx9W1wYJosCLAQTOlVpz/k8zsYjOGOPKf/X8zPqnDcYaMiq0FkAJHruyN35C6kNvfMrwIOjgdMgQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4513
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On 2023-08-29 at 16:44:19 -0700, Tony Luck wrote:
>diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
>index 030d3b409768..0d3bae523ecb 100644
>--- a/arch/x86/kernel/cpu/resctrl/core.c
>+++ b/arch/x86/kernel/cpu/resctrl/core.c
>@@ -487,6 +487,21 @@ static int arch_domain_mbm_alloc(u32 num_rmid, struct rdt_hw_domain *hw_dom)
> 	return 0;
> }
> 
>+static int get_domain_id_from_scope(int cpu, enum resctrl_scope scope)
>+{
>+	switch (scope) {
>+	case RESCTRL_L3_CACHE:
>+		return get_cpu_cacheinfo_id(cpu, 3);
>+	case RESCTRL_L2_CACHE:
>+		return get_cpu_cacheinfo_id(cpu, 2);
>+	default:
>+		WARN_ON_ONCE(1);
>+		break;
>+	}
>+
>+	return -1;
>+}

Is there some reason the "return -1" is outside of the default switch
case?

Other switch statements in this patch do have returns inside the default
case, is this one different in some way?

-- 
Kind regards
Maciej Wiecz?r-Retman