Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230829105106.1277-1-jirislaby@kernel.org> <0d86668f-4f48-cd21-b891-443e99c5c86a@kernel.org>
In-Reply-To: <0d86668f-4f48-cd21-b891-443e99c5c86a@kernel.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Wed, 30 Aug 2023 20:48:08 +0900
Message-ID: <CAK7LNATzy4Xb1s7srS=n7bEbqHXajKR44eCh6MR5Lfwz9oTfMQ@mail.gmail.com>
Subject: Re: [PATCH] kbuild: dummy-tools: support make MPROFILE_KERNEL checks
 work on BE
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>,
        "Naveen N . Rao" <naveen.n.rao@linux.vnet.ibm.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Nicholas Piggin <npiggin@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Michal Kubecek <mkubecek@suse.cz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 30, 2023 at 2:00=E2=80=AFAM Jiri Slaby <jirislaby@kernel.org> w=
rote:
>
> I deleted too few: the subject should read:
> kbuild: dummy-tools: make MPROFILE_KERNEL checks work on BE
>
> I will submit v2 if there are no other objections.


I have no objection.

If there is nothing else to fix,
I will locally fix the subject, and apply.


I also see a similar patch from Michal Suchanek,
but I like this one because the commit log
has a good explanation.


> On 29. 08. 23, 12:51, Jiri Slaby (SUSE) wrote:
> > From: Jiri Slaby <jslaby@suse.cz>
> >
> > Commit 2eab791f940b ("kbuild: dummy-tools: support MPROFILE_KERNEL
> > checks for ppc") added support for ppc64le's checks for
> > -mprofile-kernel.
> >
> > Now, commit aec0ba7472a7 ("powerpc/64: Use -mprofile-kernel for big
> > endian ELFv2 kernels") added support for -mprofile-kernel even on
> > big-endian ppc.
> >
> > So lift the check in gcc-check-mprofile-kernel.sh to support big-endian=
 too.
> >
> > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Cc: Nathan Chancellor <nathan@kernel.org>
> > Cc: Nick Desaulniers <ndesaulniers@google.com>
> > Cc: Nicolas Schier <nicolas@fjasle.eu>
> > Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> > Cc: Nicholas Piggin <npiggin@gmail.com>
> > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > Cc: Michal Kubecek <mkubecek@suse.cz>
> > ---
> >   scripts/dummy-tools/gcc | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
> > index 1db1889f6d81..07f6dc4c5cf6 100755
> > --- a/scripts/dummy-tools/gcc
> > +++ b/scripts/dummy-tools/gcc
> > @@ -85,8 +85,7 @@ if arg_contain -S "$@"; then
> >       fi
> >
> >       # For arch/powerpc/tools/gcc-check-mprofile-kernel.sh
> > -     if arg_contain -m64 "$@" && arg_contain -mlittle-endian "$@" &&
> > -             arg_contain -mprofile-kernel "$@"; then
> > +     if arg_contain -m64 "$@" && arg_contain -mprofile-kernel "$@"; th=
en
> >               if ! test -t 0 && ! grep -q notrace; then
> >                       echo "_mcount"
> >               fi
>
> --
> js
> suse labs
>


--=20
Best Regards
Masahiro Yamada