Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Aug 2023 16:19:23 +0200
From:   Martin Botka <martin.botka@somainline.org>
Subject: Re: [PATCH] firmware: smccc: Export both soc_id functions
To:     Sudeep Holla <sudeep.holla@arm.com>
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Andre Przywara <andre.przywara@arm.com>,
        Alan Ma <tech@biqu3d.com>,
        Luke Harrison <bttuniversity@biqu3d.com>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@somainline.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Martin Botka <martin@biqu3d.com>
Message-Id: <BSJ70S.HFFPUN9486BN2@somainline.org>
In-Reply-To: <CAPKp9ubXJbLQ_jOt3sp7Y8KXKyp42bzjHqbaa19LSqGMxE2yPg@mail.gmail.com>
References: <20230830-smccc_export-v1-1-6ecc7661bc94@somainline.org>
        <CAPKp9ubXJbLQ_jOt3sp7Y8KXKyp42bzjHqbaa19LSqGMxE2yPg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8BIT
Precedence: bulk

The patches using this are still WIP but the basic point is that H616 
has 2 die revisions (And those have
couple of other versions themselves) that require different uV and some 
frequencies are blacklisted on those
versions.

The driver is using these functions to read the revision (Not the 
version. It just looked like the logical
thing to export both and Andre confirmed. We can ofc drop the version 
symbol export if need be) and reads
trough the OPP table and selects the supported frequencies and uV for 
the chip its running on :)

I will try to get the cpufreq patches in order in the upcoming days and 
I will Cc you in those as well +
post a link to them in this thread :)

Cheers,
Martin

On Wed, Aug 30 2023 at 03:05:09 PM +01:00:00, Sudeep Holla 
<sudeep.holla@arm.com> wrote:
> 
> 
> On Wed, Aug 30, 2023 at 2:24 PM Martin Botka 
> <martin.botka@somainline.org> wrote:
>> arm_smccc_get_soc_id_version and arm_smccc_get_soc_id_revision
>>  need to be exported so they can be used by modules.
>>  Currently sun50i cpu freq driver is planning to use these functions.
> 
> I am not against exporting these but please post along with the 
> patches using these
> exported symbols so that no one complains about you exporting the 
> symbols mentioning
> some patches that may or may not appear in the future.
> 
> --
> Regards,
> Sudeep