Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fea72c0f-f23d-493c-beae-6bc830b9c2a2@quicinc.com>
Date:   Wed, 30 Aug 2023 14:37:08 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4] usb: typec: qcom: Update the logic of regulator enable
 and disable
To:     Guenter Roeck <linux@roeck-us.net>,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        "Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     <linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_fenglinw@quicinc.com>,
        <subbaram@quicinc.com>
References: <20230830-qcom-tcpc-v4-1-c19b0984879b@quicinc.com>
 <a2353ce6-bd39-f5ca-ad81-63b061147400@roeck-us.net>
From:   hui liu <quic_huliu@quicinc.com>
In-Reply-To: <a2353ce6-bd39-f5ca-ad81-63b061147400@roeck-us.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 8/30/2023 2:25 PM, Guenter Roeck wrote:
> On 8/29/23 20:00, Hui Liu via B4 Relay wrote:
>> From: Hui Liu <quic_huliu@quicinc.com>
>>
>> Removed the call logic of disable and enable regulator
>> in reset function. Enable the regulator in qcom_pmic_typec_start
>> function and disable it in qcom_pmic_typec_stop function to
>> avoid unbalanced regulator disable warnings.
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> Please drop.
I didn't get your mean. would you please explain it?
> 
>> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Signed-off-by: Hui Liu <quic_huliu@quicinc.com>
>> ---
>> Changes in v4:
>> - Removed regulator_enable and regulator_diable from
>> pmic_typec_pdphy_reset function. And enable regulator in
> 
> ... because I do not see the above change, and way too much changed
> in the code since I sent a Reviewed-by: to make it appropriate
> to keep it.
> 
> Actually, I don't see a difference between v3 and v4 of your patch.
> 
> Guenter
Yes, The codes are same between V3 and V4, I just update the commit log 
as Bryan said. How about I resend the V4 and update the cover letter 
like "Fixed the commit log"
> 
>> qcom_pmic_typec_pdphy_start function and disable it in
>> qcom_pmic_typec_pdphy_stop function.
>> - Link to v3: 
>> https://lore.kernel.org/r/20230828-qcom-tcpc-v3-1-e95b7afa34d9@quicinc.com
>>
>> Changes in v3:
>> - Take Bryan's proposal to remove enable/disable operation in pdphy
>> enable and pdphy disable function, then enable regulator in pdphy start
>> function and disable it in pdphy stop function.
>> - Link to v2: 
>> https://lore.kernel.org/r/20230824-qcom-tcpc-v2-1-3dd8c3424564@quicinc.com
>>
>> Changes in v2:
>> - Add Fixes tag
>> - Link to v1: 
>> https://lore.kernel.org/r/20230823-qcom-tcpc-v1-1-fa81a09ca056@quicinc.com
>> ---
>>   drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c 
>> b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
>> index bb0b8479d80f..52c81378e36e 100644
>> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
>> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
>> @@ -381,10 +381,6 @@ static int qcom_pmic_typec_pdphy_enable(struct 
>> pmic_typec_pdphy *pmic_typec_pdph
>>       struct device *dev = pmic_typec_pdphy->dev;
>>       int ret;
>> -    ret = regulator_enable(pmic_typec_pdphy->vdd_pdphy);
>> -    if (ret)
>> -        return ret;
>> -
>>       /* PD 2.0, DR=TYPEC_DEVICE, PR=TYPEC_SINK */
>>       ret = regmap_update_bits(pmic_typec_pdphy->regmap,
>>                    pmic_typec_pdphy->base + USB_PDPHY_MSG_CONFIG_REG,
>> @@ -422,8 +418,6 @@ static int qcom_pmic_typec_pdphy_disable(struct 
>> pmic_typec_pdphy *pmic_typec_pdp
>>       ret = regmap_write(pmic_typec_pdphy->regmap,
>>                  pmic_typec_pdphy->base + USB_PDPHY_EN_CONTROL_REG, 0);
>> -    regulator_disable(pmic_typec_pdphy->vdd_pdphy);
>> -
>>       return ret;
>>   }
>> @@ -447,6 +441,10 @@ int qcom_pmic_typec_pdphy_start(struct 
>> pmic_typec_pdphy *pmic_typec_pdphy,
>>       int i;
>>       int ret;
>> +    ret = regulator_enable(pmic_typec_pdphy->vdd_pdphy);
>> +    if (ret)
>> +        return ret;
>> +
>>       pmic_typec_pdphy->tcpm_port = tcpm_port;
>>       ret = pmic_typec_pdphy_reset(pmic_typec_pdphy);
>> @@ -467,6 +465,8 @@ void qcom_pmic_typec_pdphy_stop(struct 
>> pmic_typec_pdphy *pmic_typec_pdphy)
>>           disable_irq(pmic_typec_pdphy->irq_data[i].irq);
>>       qcom_pmic_typec_pdphy_reset_on(pmic_typec_pdphy);
>> +
>> +    regulator_disable(pmic_typec_pdphy->vdd_pdphy);
>>   }
>>   struct pmic_typec_pdphy *qcom_pmic_typec_pdphy_alloc(struct device 
>> *dev)
>>
>> ---
>> base-commit: bbb9e06d2c6435af9c62074ad7048910eeb2e7bc
>> change-id: 20230822-qcom-tcpc-d41954ac65fa
>>
>> Best regards,
>