Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Wed, 30 Aug 2023 15:00:07 +0100
From:   Marc Zyngier <maz@kernel.org>
To:     Martin Botka <martin.botka@somainline.org>
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Andre Przywara <andre.przywara@arm.com>,
        Alan Ma <tech@biqu3d.com>,
        Luke Harrison <bttuniversity@biqu3d.com>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@somainline.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Martin Botka <martin@biqu3d.com>
Subject: Re: [PATCH] firmware: smccc: Export both soc_id functions
In-Reply-To: <20230830-smccc_export-v1-1-6ecc7661bc94@somainline.org>
References: <20230830-smccc_export-v1-1-6ecc7661bc94@somainline.org>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <8587262deb02cf46a922ec2ec3e647d5@kernel.org>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023-08-30 14:23, Martin Botka wrote:
> arm_smccc_get_soc_id_version and arm_smccc_get_soc_id_revision
> need to be exported so they can be used by modules.
> Currently sun50i cpu freq driver is planning to use these functions.
> 

What for? I'm absolutely not keen on randomly exporting synbols
until we see what this is for.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...