Received: by 2002:a05:7412:1703:b0:e2:908c:2ebd with SMTP id dm3csp4236906rdb; Wed, 30 Aug 2023 22:45:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnnG8IQi5tsPmTnCt7/RMZeBU3GYoCx4ZsAlVRzKjr9DqQ9G344vxEoCThbQUXmhWtDLrw X-Received: by 2002:aa7:d3d2:0:b0:525:53b6:3ef9 with SMTP id o18-20020aa7d3d2000000b0052553b63ef9mr3143593edr.35.1693460745016; Wed, 30 Aug 2023 22:45:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693460744; cv=none; d=google.com; s=arc-20160816; b=yYthePVX69LUX6syyLKIbbBH1m9DcTLYHbKvslAZnLOJQWZTp+UdeQre/IzmC/eW5J J/3tDOFzp2rCQzCE0tDx/DfWMMW8Uy7uMqQ6D5HjMl44LyQx9O6JLFYK1r297Qlybe0o IkYTXy6MxSM6FEovCm5Btt1Dhs1G/2mYIWAwMng1DHJRyHgfN/N4CrUj9e+lTGNdHpy4 +qjoC2pK8twyitAcYovCAH5q0MwJbvkvXR22XKLe96Z3uRo3OhILavUo3p97Kmqw4Rwb i8FyeD92TOL3J1TvoHem37dX2wW9zI8BCQf4vxFTlKLFRrgaoVSoqfsL4V7IPHntNoQN Nx0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=QkaXLSaGdawwuEOW93k+nfxmTG8iDf9re9RcTgcirQ4=; fh=wuhl8LNMuOTSYMp24uKw+PH3nJwlBYEm/G733tbUxS0=; b=NLi75yI49FxuddFyKmeWwb87YqsqL9m9ffn9SZuWFMArFFTJoulqJvskO0WJi/X/AL Uq/0sSjYWzib5rLmnGP5SMjD7ak0TiQtRdV1UeTowcwqAO5zeLTehjYtZvyneCLqKIzm IXp1c5TG8tWU40tWIVb494bMn1te01okN0XNVaLv/Nlbud24DBptwxZfDgKATdEH5anH B2Av+fU07LTogVgpn5tcwMRaw6XzOpnMZTk/bkiMW96nNcMMFUL0lNIX7JMinDZ+5ymG t6SyURxLoifxIx7p/R2JU4zMQQE0LlG5gjHBdc+OxfLMcvHgGjwNhLVrCMEmKwJC9+wz ZZkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mxckDRQ6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id by5-20020a0564021b0500b0052a39a1a2c6si548396edb.370.2023.08.30.22.45.13; Wed, 30 Aug 2023 22:45:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mxckDRQ6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344487AbjH3X2b (ORCPT + 99 others); Wed, 30 Aug 2023 19:28:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231269AbjH3X2a (ORCPT ); Wed, 30 Aug 2023 19:28:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9623BCF; Wed, 30 Aug 2023 16:28:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 419CFB81FB8; Wed, 30 Aug 2023 19:20:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42453C433C8; Wed, 30 Aug 2023 19:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693423240; bh=QkaXLSaGdawwuEOW93k+nfxmTG8iDf9re9RcTgcirQ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mxckDRQ6+P0DK+7WQybVe8blVmGn2f6fg5F7LOuvo8Ouh0astRselAFsMF3KzI09T PaEFmC+9hKCocVhgncr7KPFD+qwovOuSZoAtDPgEuNAcaNFq/DPu9eCZe0mgfGaMfz KA1NWLaszvgLbRiJv4Xw+Im2OX9jrefNKyGYpB3Hfg5cucJzAeAAhHSifnuaK6T42P 2LjEAdX/CwJg12pNoZBC3SdFIL/p67n9b+AVEoxbsUj29dqQwScZ2uEwcqSlAIdjNa sMWueX1HVY5UFyqkvjyQMirkBukeZUq2ZTiIq4gRr1JtJUbILa+5ycCf4dMY1I+84u SE9Z9GwvoFWdg== Date: Wed, 30 Aug 2023 21:20:37 +0200 From: Wolfram Sang To: Yann Sionneau Cc: Codrin Ciubotariu , Andi Shyti , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] i2c: at91: Use dev_err_probe() instead of dev_err() Message-ID: Mail-Followup-To: Wolfram Sang , Yann Sionneau , Codrin Ciubotariu , Andi Shyti , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230825143234.38336-1-yann@sionneau.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gFyj0w2shawdgBoy" Content-Disposition: inline In-Reply-To: <20230825143234.38336-1-yann@sionneau.net> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gFyj0w2shawdgBoy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 25, 2023 at 04:32:34PM +0200, Yann Sionneau wrote: > Change > if (IS_ERR(x)) { dev_err(...); return PTR_ERR(x); } > into > return dev_err_probe() >=20 > Also, return the correct error instead of hardcoding -ENODEV > This change has also the advantage of handling the -EPROBE_DEFER situatio= n. >=20 > Signed-off-by: Yann Sionneau Applied to for-next, thanks! --gFyj0w2shawdgBoy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmTvloUACgkQFA3kzBSg KbbqXxAAkTSIHoQf+8sjpUea7IT9kzaCBjxJ9rTkAtAn1XrUk7d67KuizLumUD3S L7ByVvL6nZ++JbTA2H/JRKf8AllGYc6wapJR2GNVLF2Oyd/uIQLzWQmIOTeimqci VYt6vUhM+BeQQJvxCvayJqxo/oLUc45aiKTh9YcIyyCVn/kdMk0fl3TiF3xhBecR 7iJSlBt/0mDz9nfiIxmlM1sBOLqbAnxlDBC7RH9gmxzp2JPGJ0ExZnvGS1x7Q0/u +zk0QlXue9MUg5Sr9LK/GkZRJAANCVta+Or7jRwGki/j7+dVMX8DWJe2pImyb6Ug zcJiEY3DdkxsJN6gQxcWiqNOSF9tOeEMwwj0XVg3erO3vEuumiuvMhCUwK8YW5a6 Ip9DSAvt+YHNQsH+WF+AryV65JARUpYaLuK8IK8oFCtQB9/W2bu4v4fBY3ABooUv S8RiXZMBDsLne8bwnt+EacRQdEIMMtjBzxPQVV32MnDIbjGJxkL3hszGXvnUy3p8 cMlJUneyKoP3sY5iH+syoYQC4Gmd+tbhbOqbklygLQ/iPiNDbncbqRbEmYkrF8C9 OApOB/jmC982w02ijQ/U+il0meBQcYoKFEnbB3bvAOr+x4320ZEV/kZl2j4B1xD6 nETesOuaieit1WZh/qzyS+FZ27CK8RtBAe5wb9zp2DPSo6jIuZA= =wDy4 -----END PGP SIGNATURE----- --gFyj0w2shawdgBoy--