Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756133AbXKENA4 (ORCPT ); Mon, 5 Nov 2007 08:00:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754787AbXKENAs (ORCPT ); Mon, 5 Nov 2007 08:00:48 -0500 Received: from vervifontaine.sonytel.be ([80.88.33.193]:61147 "EHLO vervifontaine.sonycom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754704AbXKENAr (ORCPT ); Mon, 5 Nov 2007 08:00:47 -0500 Date: Mon, 5 Nov 2007 14:00:45 +0100 (CET) From: Geert Uytterhoeven To: stable@kernel.org cc: Andrew Morton , LKML , Li Zefan , Geoff Levand Subject: Re: [PATCH 5/6] drivers/video/ps3fb: fix memset size error In-Reply-To: Message-ID: References: <472E7FBC.7020906@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-584337861-1769223260-1194267645=:28623" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2084 Lines: 60 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---584337861-1769223260-1194267645=:28623 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Mon, 5 Nov 2007, Geert Uytterhoeven wrote: > On Mon, 5 Nov 2007, Li Zefan wrote: > > The size passing to memset is wrong. > > > > Signed-off-by Li Zefan > > Acked-by: Geert Uytterhoeven As this leaks 24 bytes of uninitialized stack to user space, probably this should be applied to -stable, too? > > --- > > drivers/video/ps3fb.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c > > index b3463dd..75836aa 100644 > > --- a/drivers/video/ps3fb.c > > +++ b/drivers/video/ps3fb.c > > @@ -727,7 +727,7 @@ static int ps3fb_blank(int blank, struct fb_info *info) > > > > static int ps3fb_get_vblank(struct fb_vblank *vblank) > > { > > - memset(vblank, 0, sizeof(&vblank)); > > + memset(vblank, 0, sizeof(*vblank)); > > vblank->flags = FB_VBLANK_HAVE_VSYNC; > > return 0; > > } With kind regards, Geert Uytterhoeven Software Architect Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ Sony Network and Software Technology Center Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619 ---584337861-1769223260-1194267645=:28623-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/