Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756620AbXKENDz (ORCPT ); Mon, 5 Nov 2007 08:03:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754703AbXKENDr (ORCPT ); Mon, 5 Nov 2007 08:03:47 -0500 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:52051 "EHLO the-village.bc.nu" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754272AbXKENDp (ORCPT ); Mon, 5 Nov 2007 08:03:45 -0500 Date: Mon, 5 Nov 2007 13:03:30 +0000 From: Alan Cox To: Tejun Heo Cc: albertl@mail.com, albertcc@tw.ibm.com, Daniel Drake , Jeff Garzik , Jens Axboe , linux list , linux-ide@vger.kernel.org Subject: Re: "Fix ATAPI transfer lengths" causes CD writing regression Message-ID: <20071105130330.06a22f7a@the-village.bc.nu> In-Reply-To: <472E5E5C.8040308@gmail.com> References: <47274A5F.6070409@gentoo.org> <20071030153417.59b9182c@the-village.bc.nu> <47276DCA.1000808@gentoo.org> <20071030190153.373c9347@the-village.bc.nu> <47278439.4030801@gentoo.org> <20071031114958.210bd7cc@the-village.bc.nu> <20071031115754.GK5059@kernel.dk> <4729A0DF.20800@garzik.org> <20071101105335.1f20bab3@the-village.bc.nu> <4729B3EA.6040707@garzik.org> <20071101141501.3746cec2@the-village.bc.nu> <4729F1BB.20306@gentoo.org> <4729F8F1.4040103@gmail.com> <472B946F.4030004@gentoo.org> <472BCC18.7070503@gmail.com> <472CD3F3.7050701@gentoo.org> <472D0D4A.70404@gmail.com> <472D445B.1080005@tw.ibm.com> <20071104234205.7627d007@the-village.bc.nu> <472E5E5C.8040308@gmail.com> X-Mailer: Claws Mail 2.10.0 (GTK+ 2.10.14; i386-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 30 On Mon, 05 Nov 2007 09:05:48 +0900 Tejun Heo wrote: > Alan Cox wrote: > >> Maybe we could set a limit here. If the ATAPI device keeps DRQ=1 and > >> exceeds the limit, we consider it as HSM violation and have EH handle it. > > > > On a DMA transfer its basically out of our control (and a PIO drain will > > lock some controllers solid until power cycle), > > Do such controllers lock up on PIO draining after PIO transfers too? > Can you tell which are those controllers? Promise PDC202xx will lock on a PIO drain of a DMA transfer or (if you reset it before you drain) on a PIO drain of a PIO transfer. > > but on PIO we know we > > never set a chunk size over 64K, so if we exceed 64K its time to apply a > > larger hammer > > Draining is related to the amount of data the drive responds not to the > chunk size. I agree 64k should be enough for most cases but I think > there can be corner cases where this doesn't hold. Tapes perhaps yes ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/