Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230825-strncpy-habanalabs-combined-v1-1-daa05a89b7e3@google.com>
 <202308251513.0F6BF9FEE6@keescook>
In-Reply-To: <202308251513.0F6BF9FEE6@keescook>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Thu, 31 Aug 2023 16:09:47 +0300
Message-ID: <CAFCwf12yWnz6wP+3Th=QiTkeMhiPjn6c4sg2b3-2fE55w3pyEQ@mail.gmail.com>
Subject: Re: [PATCH] accel/habanalabs: refactor deprecated strncpy to strscpy_pad
To:     Kees Cook <keescook@chromium.org>
Cc:     Justin Stitt <justinstitt@google.com>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        linux-hwmon@vger.kernel.org, linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Aug 26, 2023 at 1:13=E2=80=AFAM Kees Cook <keescook@chromium.org> w=
rote:
>
> On Fri, Aug 25, 2023 at 10:09:51PM +0000, Justin Stitt wrote:
> > `strncpy` is deprecated for use on NUL-terminated destination strings [=
1].
> >
> > We see that `prop->cpucp_info.card_name` is supposed to be
> > NUL-terminated based on its usage within `__hwmon_device_register()`
> > (wherein it's called "name"):
> > |     if (name && (!strlen(name) || strpbrk(name, "-* \t\n")))
> > |             dev_warn(dev,
> > |                      "hwmon: '%s' is not a valid name attribute, plea=
se fix\n",
> > |                      name);
> >
> > A suitable replacement is `strscpy_pad` [2] due to the fact that it
> > guarantees both NUL-termination and NUL-padding on its destination
> > buffer.
> >
> > NUL-padding on `prop->cpucp_info.card_name` is not strictly necessary a=
s
> > `hdev->prop` is explicitly zero-initialized but should be used
> > regardless as it gets copied out to userspace directly -- as per Kees' =
suggestion.
> >
> > Link: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on=
-nul-terminated-strings[1]
> > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en=
.html [2]
> > Link: https://github.com/KSPP/linux/issues/90
> > Cc: linux-hardening@vger.kernel.org
> > Signed-off-by: Justin Stitt <justinstitt@google.com>
>
> Thanks for the consolidation and refresh. :)
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> --
> Kees Cook
Pushed to habanalabs-next-6.7

Thanks for the patch,
Oded.